-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General improvements #53
Conversation
Superb work. |
MS just announced a few days ago that they were declining the request to
develop a Linux client, which has been in the backlog Dev queue since the
product's beta release, but within two days put it back in as a backlog
request due to backlash. So... Maybe someday?
Thank you all for your efforts on this great work around.
…On Fri, Oct 19, 2018, 11:06 AM IsmaelMartinez ***@***.***> wrote:
Trying to sort most of the issues and others that we have found while
using it.
This should fix #7 <#7>
#9 <#9> #12
<#12> #14
<#14> #37
<#37> #42
<#42> #45
<#45> and #49
<#49>
and maybe #11 <#11> and
#50 <#50>
Thanks a lot to @ivelkov <https://github.com/ivelkov> , JamieMagee and
all the other contributors to this project. I hope microsoft implements a
proper client or integrates with the html5 browser notifications soon as
this will always be a bit of a hack.
------------------------------
You can view, comment on, or merge this pull request online at:
#53
Commit Summary
- Switch gitlab-ci for travis-ci
- Bump version
- Update README links
- Switch to yarn
- Upgrade to electron 3.0.0
- Update user agent strings
- Replace open with open.
- initial wip to authenticate into teams from the linux app
- Adding extra notifications and trying to whitelist the authentication
- Minor chanages and adding log for debuging
- adding more logs for notifications
- Playing aroudn with a service worker to communicate between the
browser and the eletron app
- adding number of notification
- cleanup of readme and package.json files
- Adding the text form the open dialogs if any present
- Merge branch 'authentications'
- adding the innerText only if not undefined
- initializing the elements... forgot I was in javascript
- adding newline to the notification message. Testing in a virtual
machine so doing commits for every test
- adding markup with inline conditional
- adding markup with inline conditional
- removing the p markup and replacing it with a br
- removing the br altogether and trying to keep the you got x
notifications part
- we should not need to add a notification when we go down to 0
- changing the message in the notification
- removing some unsafe webpreferences
- adding an event listener to the browser part (renderer) to be able
to zoom in with the ctrl++ and zoom out with ctrl+-
- Incremeting the version number
- Adding zoom preferences by using the menu role options
- opening the whitelist
- Changing the username from upercase to lowercase... I don't want
people to think I am shouting at them
- Adding the zoomclick in the browser as the shorcuts from the
electron role funciontality are not working
- Adding the zoom into the browser window
- Merge branch 'zoomclick'
- increasing version
- Improving a bit more the notifications by adding the full text and
not using jquery (using document.getElementById)
- Removing pacman and tar.gz in the package.json as it only selects 3
random packages in github at the moment
- adding css to remove the download app button and to stop the css
animations after one iteration (as they destroy your cpu)
- Adding a loging dialog when ntlm fails
- wip for adding the login dialog for when the ntlm fails (block by
company)
- adding the login dialog and cleaning a bit the code
- increasing the version number to 0.1.3
- Referencing the main window in the login window as a parent/child to
improve usage. Increasing the version number.
- removing commented out code
- Adding reload of the app if failed to load (as workaround to the
login callback only allowing one call)
- Adding some logs to the icon to identify an issue where the tray
icon is not showing
- Commenting some not use code in preparation to remove it
- reverting to version 0.1.3 as it was never release
- Trying to fix the mentions issue by reverting not published changes
by ivanov that seem to be the ones causing the issue
- Increasing version to 0.1.4 in preparation to add the fix for
@mentions.
- * Commenting the config/index file as yargs was causing an issue
with the @mentions disapearing after hitting space.
- fixing code after merge issue
- Changing the partition and removing the ntlm authentication as it
seems to create som issues
- changint the partition and removing the reload when failed to load
- increasing vesrion number to 0.1.4. Not sure why it got decrease
probably while playing with gitkraken
- Adding the reload again
- * Adding back the command arguments and extending them.
- Merge pull request #2 from IsmaelMartinez/0.1.5
File Changes
- *D* .gitlab-ci.yml
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-0> (24)
- *A* .travis.yml
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-1> (24)
- *A* .vscode/launch.json
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-2> (16)
- *M* README.md
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-3> (47)
- *M* app/lib/browser/index.js
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-4> (15)
- *M* app/lib/browser/native-notifications.js
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-5> (36)
- *M* app/lib/browser/tray-notifications.js
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-6> (33)
- *A* app/lib/browser/zoom.js
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-7> (21)
- *M* app/lib/config/index.js
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-8> (39)
- *M* app/lib/index.js
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-9>
(108)
- *A* app/lib/login/formSender.js
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-10>
(12)
- *A* app/lib/login/index.js
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-11>
(28)
- *A* app/lib/login/login.html
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-12>
(28)
- *M* app/lib/menus/help.js
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-13>
(12)
- *M* app/lib/menus/index.js
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-14> (5)
- *M* app/lib/menus/preferences.js
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-15> (8)
- *D* app/package-lock.json
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-16>
(396)
- *M* app/package.json
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-17> (7)
- *A* app/yarn.lock
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-18>
(396)
- *D* package-lock.json
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-19>
(2820)
- *M* package.json
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-20>
(30)
- *A* yarn.lock
<https://github.com/ivelkov/teams-for-linux/pull/53/files#diff-21>
(2060)
Patch Links:
- https://github.com/ivelkov/teams-for-linux/pull/53.patch
- https://github.com/ivelkov/teams-for-linux/pull/53.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#53>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZuel8GhEkyXIUEgKKqx4RYWCTKCL5Qbks5umfiWgaJpZM4Xwpsc>
.
|
@CircuitByrd yeah, to be honest, if they implement the notifications in html5 the main issue of using the browser will be gone. The "solutions" in my branch are pretty much a series of hacks (like the stopping the emojis animations after one iteration as it was trashing our CPU's). Hopefully it helps people around. @sgnls , it will be good to get your take in the authentication part (specially in the ntlm "magic"). basically the following: That will be much appreciated. |
Trying to sort most of the issues and others that we have found while using it.
This should fix #7 #9 #12 #14 #37 #42 #45 and #49
and maybe #11 and #50
Thanks a lot to @ivelkov , JamieMagee and all the other contributors to this project. I hope microsoft implements a proper client or integrates with the html5 browser notifications soon as this will always be a bit of a hack.