Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvements #53

Closed
wants to merge 0 commits into from
Closed

Conversation

IsmaelMartinez
Copy link

Trying to sort most of the issues and others that we have found while using it.

This should fix #7 #9 #12 #14 #37 #42 #45 and #49

and maybe #11 and #50

Thanks a lot to @ivelkov , JamieMagee and all the other contributors to this project. I hope microsoft implements a proper client or integrates with the html5 browser notifications soon as this will always be a bit of a hack.

@sgnls
Copy link

sgnls commented Oct 19, 2018

Superb work.

@CircuitByrd
Copy link

CircuitByrd commented Oct 19, 2018 via email

@IsmaelMartinez
Copy link
Author

@CircuitByrd yeah, to be honest, if they implement the notifications in html5 the main issue of using the browser will be gone. The "solutions" in my branch are pretty much a series of hacks (like the stopping the emojis animations after one iteration as it was trashing our CPU's). Hopefully it helps people around.

@sgnls , it will be good to get your take in the authentication part (specially in the ntlm "magic"). basically the following:
app.commandLine.appendSwitch('auth-negotiate-delegate-whitelist','*'); app.commandLine.appendSwitch('enable-ntlm-v2','true');
and if you really want to get your hands dirty, the fallback popup (basic auth) dialog.

That will be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

White page after refresh
3 participants