make all sensors 'reportPath' properties multi-value

1. fixes SonarOpenCommunity#1384

Literaly all sensors derived from `CxxReportSensor` as well as `CxxSquidSensor`
use use the method `CxxReportSensor::getReports()` in order to access the
reporth paths. This method expects the `*.reportPath` property to be
a multi-value one. So fix the property access

* use `getStringArray()` method for parsing
* mark corresponding properties as multi-value

2. fixes SonarOpenCommunity#1376

While working on (1) I've found out, that the property
`UnitTestConfiguration.NUNIT_TEST_RESULTS_PROPERTY_KEY` is not public
accessible. This contradicts to the SonarOpenCommunity#1376.

On the other hand, if there should be no soupport for NUnit,
either the property must be marked as deprecated or the NUnit support
has to be removed completely. Please review.

cxx-sensors/src/main/java/org/sonar/cxx/sensors/utils/CxxReportSensor.java

@@ -132,11 +132,11 @@ public static List<File> getReports(Configuration settings,
       return reports;
     }
 
-    String reportPathString = settings.get(genericReportKeyData).orElse("");
-    if (reportPathString.isEmpty()) {
+    String[] reportPathString = settings.getStringArray(genericReportKeyData);
+    if (reportPathString.length == 0) {
       LOG.info("Undefined report path value for key '{}'", genericReportKeyData);
     } else {
-      List<String> reportPaths = Arrays.asList(splitProperty(reportPathString));
+      List<String> reportPaths = Arrays.asList(reportPathString);
 
       List<String> includes = normalizeReportPaths(moduleBaseDir, reportPaths);
       if (LOG.isDebugEnabled()) {

sonar-c-plugin/src/main/java/org/sonar/plugins/c/CPlugin.java

@@ -174,6 +174,7 @@ private static List<PropertyDefinition> generalProperties() {
           + USE_ANT_STYLE_WILDCARDS_1)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(9)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxSquidSensor.REPORT_CHARSET_DEF)
@@ -206,6 +207,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
       )
       .subCategory(subcateg)
       .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+      .multiValues(true)
       .index(1)
       .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxCppCheckRuleRepository.CUSTOM_RULES_KEY)
@@ -222,6 +224,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + USE_ANT_STYLE_WILDCARDS_1)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(3)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxValgrindRuleRepository.CUSTOM_RULES_KEY)
@@ -238,6 +241,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + USE_ANT_STYLE_WILDCARDS_1)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(5)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxPCLintSensor.REPORT_PATH_KEY)
@@ -246,6 +250,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + "projects root." + USE_ANT_STYLE_WILDCARDS_1)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(5)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxPCLintRuleRepository.CUSTOM_RULES_KEY)
@@ -262,6 +267,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + "relative to projects root." + USE_ANT_STYLE_WILDCARDS_1)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(7)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxRatsRuleRepository.CUSTOM_RULES_KEY)
@@ -278,6 +284,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + USE_ANT_STYLE_WILDCARDS_1)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(9)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxVeraxxRuleRepository.CUSTOM_RULES_KEY)
@@ -296,6 +303,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + "here</a> for details.")
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(11)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxOtherRepository.RULES_KEY)
@@ -314,6 +322,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + USE_ANT_STYLE_WILDCARDS_2)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(13)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxClangTidySensor.REPORT_CHARSET_DEF)
@@ -338,6 +347,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + USE_ANT_STYLE_WILDCARDS_2)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(16)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxClangSARuleRepository.CUSTOM_RULES_KEY)
@@ -359,6 +369,7 @@ private static List<PropertyDefinition> compilerWarningsProperties() {
           + USE_ANT_STYLE_WILDCARDS_1)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(1)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxCompilerVcSensor.REPORT_CHARSET_DEF)
@@ -393,6 +404,7 @@ private static List<PropertyDefinition> compilerWarningsProperties() {
           + USE_ANT_STYLE_WILDCARDS_1)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(5)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxCompilerGccSensor.REPORT_CHARSET_DEF)
@@ -434,6 +446,7 @@ private static List<PropertyDefinition> testingAndCoverageProperties() {
           + "here</a> for supported formats." + USE_ANT_STYLE_WILDCARDS_1)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(1)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxXunitSensor.REPORT_PATH_KEY)
@@ -443,6 +456,7 @@ private static List<PropertyDefinition> testingAndCoverageProperties() {
           + "here</a> for supported formats." + USE_ANT_STYLE_WILDCARDS_1)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(6)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxXunitSensor.XSLT_URL_KEY)

sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/CxxPlugin.java

@@ -183,6 +183,7 @@ private static List<PropertyDefinition> generalProperties() {
           + USE_ANT_STYLE_WILDCARDS)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(9)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxSquidSensor.REPORT_CHARSET_DEF)
@@ -215,6 +216,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
       )
       .subCategory(subcateg)
       .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+      .multiValues(true)
       .index(1)
       .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxCppCheckRuleRepository.CUSTOM_RULES_KEY)
@@ -231,6 +233,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + USE_ANT_STYLE_WILDCARDS)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(3)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxValgrindRuleRepository.CUSTOM_RULES_KEY)
@@ -247,6 +250,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + USE_ANT_STYLE_WILDCARDS)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(5)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxPCLintSensor.REPORT_PATH_KEY)
@@ -255,6 +259,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + "  root." + USE_ANT_STYLE_WILDCARDS)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(5)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxPCLintRuleRepository.CUSTOM_RULES_KEY)
@@ -271,6 +276,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + " relative to projects root." + USE_ANT_STYLE_WILDCARDS)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(7)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxRatsRuleRepository.CUSTOM_RULES_KEY)
@@ -287,6 +293,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + USE_ANT_STYLE_WILDCARDS)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(9)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxVeraxxRuleRepository.CUSTOM_RULES_KEY)
@@ -304,6 +311,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + "/wiki/Extending-the-code-analysis'>here</a> for details.")
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(11)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxOtherRepository.RULES_KEY)
@@ -321,6 +329,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + "<a href='https://ant.apache.org/manual/dirtasks.html'>Ant-style wildcards</a> are at your service.")
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(13)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxClangTidySensor.REPORT_CHARSET_DEF)
@@ -345,6 +354,7 @@ private static List<PropertyDefinition> codeAnalysisProperties() {
           + "<a href='https://ant.apache.org/manual/dirtasks.html'>Ant-style wildcards</a> are at your service.")
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(16)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxClangSARuleRepository.CUSTOM_RULES_KEY)
@@ -384,6 +394,7 @@ private static List<PropertyDefinition> compilerWarningsProperties() {
           + USE_ANT_STYLE_WILDCARDS)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(1)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxCompilerVcSensor.REPORT_CHARSET_DEF)
@@ -418,6 +429,7 @@ private static List<PropertyDefinition> compilerWarningsProperties() {
           + USE_ANT_STYLE_WILDCARDS)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(5)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxCompilerGccSensor.REPORT_CHARSET_DEF)
@@ -455,14 +467,14 @@ private static List<PropertyDefinition> testingAndCoverageProperties() {
 
     properties.add(
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxCoverageSensor.REPORT_PATH_KEY)
-        .multiValues(true)
         .name("Unit test coverage report(s)")
         .description("List of paths to reports containing unit test coverage data, relative to projects root."
           + " The values are separated by commas."
           + " See <a href='https://github.com/SonarOpenCommunity/sonar-cxx/wiki/Get-code-coverage-metrics'>"
           + "here</a> for supported formats.")
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(1)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxXunitSensor.REPORT_PATH_KEY)
@@ -472,6 +484,7 @@ private static List<PropertyDefinition> testingAndCoverageProperties() {
           + "here</a> for supported formats." + USE_ANT_STYLE_WILDCARDS)
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .multiValues(true)
         .index(2)
         .build(),
       PropertyDefinition.builder(LANG_PROP_PREFIX + CxxXunitSensor.XSLT_URL_KEY)
@@ -500,6 +513,15 @@ private static List<PropertyDefinition> testingAndCoverageProperties() {
         .subCategory(subcateg)
         .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
         .index(5)
+        .build(),
+      PropertyDefinition.builder(LANG_PROP_PREFIX
+        + UnitTestConfiguration.NUNIT_TEST_RESULTS_PROPERTY_KEY)
+        .multiValues(true)
+        .name("NUnit Test Reports Paths")
+        .description("Example: \"TestResult.xml\", \"TestResult1.xml,TestResult2.xml\" or \"C:/TestResult.xml\"")
+        .subCategory(subcateg)
+        .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
+        .index(6)
         .build()
     );
     return properties.build();

sonar-cxx-plugin/src/test/java/org/sonar/plugins/cxx/CxxPluginTest.java

@@ -35,6 +35,6 @@ public void testGetExtensions() throws Exception {
     Plugin.Context context = new Plugin.Context(runtime);
     CxxPlugin plugin = new CxxPlugin();
     plugin.define(context);
-    assertThat(context.getExtensions()).hasSize(81);
+    assertThat(context.getExtensions()).hasSize(82);
   }
 }