Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the new channel layout (part 1) #3374

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

SamantazFox
Copy link
Member

Closes #3371

@unixfox
Copy link
Member

unixfox commented Oct 31, 2022

Interesting findings: https://www.reddit.com/r/NewPipe/comments/yie0ca/workarounds_for_the_new_youtube_channel_tabs/

@SamantazFox SamantazFox force-pushed the new-channel-layout branch 4 times, most recently from 2766b27 to a28295f Compare November 1, 2022 00:43
@SamantazFox
Copy link
Member Author

Current state of the PR: channel videos are back, but paging is still broken.

@schleussinger
Copy link

[46a63e6] works on my instance as described (Channel list is present, paging always returns page 1). Thanks!

@iv-org iv-org deleted a comment from schleussinger Nov 1, 2022
@sonicrules1234
Copy link

Livestreams (both live and archived) are still missing from the channel pages

@SamantazFox
Copy link
Member Author

SamantazFox commented Nov 2, 2022

[46a63e6] works on my instance as described (Channel list is present, paging always returns page 1). Thanks!

That's quite surprising! This is intended for the "shorts" tab. But glad it's working for you!

Livestreams (both live and archived) are still missing from the channel pages

This will be addressed in the future ^^
For now, I'd like to have at least the channel videos back up.

@SamantazFox SamantazFox changed the title Add support for the new channel layout Add support for the new channel layout (part 1) Nov 2, 2022
@SamantazFox SamantazFox marked this pull request as ready for review November 2, 2022 17:48
@SamantazFox SamantazFox requested a review from a team as a code owner November 2, 2022 17:48
@SamantazFox SamantazFox requested review from unixfox and removed request for a team November 2, 2022 17:48
@SamantazFox
Copy link
Member Author

poke @unixfox: I think we should merge this PR as-is to at least provide the latest videos of a channel.
It's not perfect (continuations are still broken), but would at least help with #3371

@SamantazFox SamantazFox merged commit 09942de into iv-org:master Nov 2, 2022
@SamantazFox SamantazFox deleted the new-channel-layout branch November 2, 2022 21:09
@unixfox
Copy link
Member

unixfox commented Nov 3, 2022

Ever tried to see if the pagination is easier on clients like MWEB or ANDROID?

@SamantazFox
Copy link
Member Author

Ever tried to see if the pagination is easier on clients like MWEB or ANDROID?

Nope, thanks for the idea! (Though I'm pretty sure it won't work on android, given recent exchanges with TiA4f8R over on matrix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] List of videos on a channel page is incorrect - no pagination channel
4 participants