add option to disable quic #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More than half of a day of testing on yewtu.be and everything works as fine as it would with quic enabled. This doesn't reduce the memory usage and CPU usage at all though. I still get a lot of memory used on Invidious processes, almost the same memory consumption as running with quic. |
TheFrenchGhosty
added
the
unfinished
saltycrys
approved these changes
Apr 17, 2021
TheFrenchGhosty
removed
the
unfinished
|
This pull request has been automatically locked since there has not been any activity in it in the last 30 days. If you want to tell us about needed or wanted changes or if problems related to this code are discovered, feel free to open an issue or a new pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary use of quic is to avoid certain google capchas (with other potential benefits). But, for small instances this isn't necessary and also brings with it a whole bunch of new complexity.
related discussion: #957