Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link[rel="alternate"] pointing to YouTube version #1730

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

notpushkin
Copy link
Contributor

@notpushkin notpushkin commented Jan 30, 2021

I propose adding a <link> element (or a Link HTTP header, maybe) pointing to YouTube version of a video.

Right now, automated user agents (like youtube-dl) have to keep a list of known Invidious instances, which gets out of date sometimes and needs to be kept in sync manually. This PR would allow them to know that this is a YouTube video and they can directly download it from there (youtube-dl doesn't do that yet, but I'm working on implementing this).

@TheFrenchGhosty TheFrenchGhosty added the need-code-review A crystal developper need to check if the code is correct. label Feb 1, 2021
@GauthierPLM
Copy link
Contributor

Looks good to me. The change follows W3C specs and make senses for an app like Invidious.

@Perflyst Perflyst merged commit ec82c1f into iv-org:master Feb 4, 2021
@Perflyst
Copy link
Contributor

Perflyst commented Feb 4, 2021

Thanks!

@github-actions
Copy link

github-actions bot commented Jun 9, 2021

This pull request has been automatically locked since there has not been any activity in it in the last 30 days. If you want to tell us about needed or wanted changes or if problems related to this code are discovered, feel free to open an issue or a new pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
need-code-review A crystal developper need to check if the code is correct.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants