Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to subscribe to playlist (#17) #1182

Merged
merged 1 commit into from
Jun 13, 2020
Merged

Allow user to subscribe to playlist (#17) #1182

merged 1 commit into from
Jun 13, 2020

Conversation

DmitrySandalov
Copy link
Contributor

No description provided.

@omarroth
Copy link
Contributor

Fantastic! Thank you!

Unfortunately I don't have the time to give this the review it deserves. I've invited you as a collaborator, please feel free to merge when you think it's ready.

@DmitrySandalov
Copy link
Contributor Author

This has been deployed to my own instance for a few weeks and it looks to be working as expected.

The current implementation adds control buttons for playlists created by others to subscribe/unsubscribe. After subscribing to playlist it is displayed on the Playlists page under separate header 'Saved Playlists' (as on YT). Own playlists header is renamed to 'Created Playlists'.

There is space for further improvement, but I'd rather leave this commit as is and work on other related issues separately:

  • thumbnails for saved playlists
  • hiding already watched videos in saved playlists
  • updates when the remote playlist changes (video_count, description, etc)
  • showing new videos from saved playlists on the main subscription page

So, if you don't mind, I'll go ahead and merge this request. Thank you.

20200531150001
20200531145814
20200531150222

@DmitrySandalov DmitrySandalov merged commit 338dc32 into iv-org:master Jun 13, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any activity in it in the last 30 days. If you want to tell us about needed or wanted changes or if problems related to this code are discovered, feel free to open an issue or a new pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants