Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify installation process and improve documentation #1

Merged
merged 6 commits into from
May 30, 2024

Conversation

perennialtech
Copy link
Contributor

This PR aims to simplify the deployment of the Helm chart and improve the accompanying documentation.

  • values.yaml

    • Updated external links.
    • Added a note on potential deadlock issues when replicaCount is greater than 1.
  • README.md

    • Added a section on removing PostgreSQL PVCs.
    • Removed section on creating PostgreSQL init scripts manually as they are now included by default.

@JuniorJPDJ
Copy link
Collaborator

JuniorJPDJ commented May 27, 2024

I'm not sure if holding sql files inside the chart is a good idea as it will become out of date quickly.
If you can propose (or even better - implement) some solution to make it not become out of date I'm OK with your solution :D

Thanks for the contribution!

@unixfox
Copy link
Member

unixfox commented May 27, 2024

IIRC the sql files are included in the docker image no? Maybe we should.

@JuniorJPDJ
Copy link
Collaborator

hmm, maybe we should merge this and then create issue to fix later, as this PR is correct?

@unixfox
Copy link
Member

unixfox commented May 30, 2024

ok for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants