-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example and maybe add typing #40
Comments
The README should be updated to Python 3 IMO. And in Python 3 we get bytes, not strings. Example:
|
Only Python 3 is supported now, so this is way overdue. This addresses parts of issue #40.
I don't know immediately whether one can add typing hints to C modules, or how easy/difficult it is, but the docstrings are easy to change. The (temporary) output of the docs is here: https://pyxattr--46.org.readthedocs.build/46/module.html and looks about right, although there are a number of other Python 2-related comments to remove. So I'll commit this docstring change first, and then look into the typing aspect. |
Only Python 3 is supported now, so this is way overdue. This addresses parts of issue #40.
Hello,
I've started to use this project to annotate etag headers on downloaded files.
The example looks like it uses strings, but actually all strings get converted to bytes, so when reading it's all bytes… so initially it didn't match… because the type didn't match.
I understand that breaking API to just accept bytes and error out otherwise is maybe a bit much, but it'd be nice to have the examples use b'whatever' to reflect how it works.
Thanks
The text was updated successfully, but these errors were encountered: