Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting arbitrary column's values from the "meaning" field #73

Open
rrnewton opened this issue Dec 7, 2014 · 0 comments
Open
Milestone

Comments

@rrnewton
Copy link
Member

rrnewton commented Dec 7, 2014

The parameter settings take the form Set meaning implementation, where meaning is a note to the HSBencher infrastructure and implementation is how it gets accomplished, for example, Set (Threads 3) (RuntimeEnv "THREADS" "3")).

As pointed out by @BlairArchibald, really we want to be able to set any field of the output benchmark result in this way, not just "THREADS" and "VARIANT". In particular, while we can add Custom fields, we can't currently set their values in this way, only via harvesters.

Maybe DefaultParamMeaning should just be replaced with Maybe (String,String) which would set an arbitrary column, e.g. Just ("THREADS","3") or Just ("MYCOLUMN","foo")? It would be a little inelegant that certain strings are special (like "THREADS"), but that's already the case in having a built-in benchmark schema at all...

rrnewton added a commit that referenced this issue Dec 8, 2014
…ramMeaning, but don't yet handle all the new forms.
@rrnewton rrnewton added this to the 2.0 milestone Apr 26, 2015
rrnewton added a commit that referenced this issue Apr 29, 2015
…ark results

The idea is that a single process may now issue START_BENCHMARK/END_BENCHMARK tags
and thus report results for distinct benchmarks.  These "sub-benchmarks" inherit all
the settings from the benchmark config that launched the process, but they may
override those settings by outputting tags.

Multilpe trials still work, and when each trial reports on multiple benchmarks, the
results are "zipped" together.

This is the major change that will enable #73.

Note, this commit creates a large amount of dead code.  These disconnected functions
will be harvested in a dedicated future commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant