Configurable MaxNumberOfOptions znuny#575

itweserems · Jun 27, 2024 · 1ab41a6 · 1ab41a6
1 parent ad36fe5
commit 1ab41a6
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/Kernel/Config/Files/XML/Framework.xml b/Kernel/Config/Files/XML/Framework.xml
@@ -550,6 +550,13 @@
             <Item ValueType="String" ValueRegex="^[0-9]{1,5}$">6000</Item>
         </Value>
     </Setting>
+    <Setting Name="MaxDropdownOptions" Required="1" Valid="1">
+        <Description Translatable="1">Sets the maximum number of dropdown field values before the select layout will be changed for performance reasons.</Description>
+        <Navigation>Frontend::Base</Navigation>
+        <Value>
+            <Item ValueType="String" ValueRegex="^\d*$">1000</Item>
+        </Value>
+    </Setting>
     <Setting Name="Frontend::MenuDragDropEnabled" Required="1" Valid="1">
         <Description Translatable="1">Turns on drag and drop for the main navigation.</Description>
         <Navigation>Frontend::Base</Navigation>

diff --git a/Kernel/Language/de.pm b/Kernel/Language/de.pm
@@ -5636,6 +5636,8 @@ sub Data {
             'Automatischer Zeilenumbruch in Textnachrichten nach x-Zeichen.',
         'Sets the number of lines that are displayed in text messages (e.g. ticket lines in the QueueZoom).' =>
             'Legt die Anzahl an Zeilen fest, die von Textnachrichten angezeigt werden sollen (z. B. von Tickets in der Queue-Ansicht).',
+        'Sets the maximum number of dropdown field values before the select layout will be changed for performance reasons.' =>
+            'Legt die maximale Anzahl an Werten fest, bevor das Auswahlfeld-Layout zu Performancezwecken geändert wird.',
         'Turns on drag and drop for the main navigation.' => 'Aktiviert Drag und Drop für die Hauptnavigation.',
         'Defines the date input format used in forms (option or input fields).' =>
             'Definiert das benutzte Datumseingabeformat in Formularen (Option für Eingabefelder).',

diff --git a/Kernel/Output/HTML/Layout.pm b/Kernel/Output/HTML/Layout.pm
@@ -508,6 +508,14 @@ sub Block {
         Data => $Param{Data},
         };
 
+    # For performance reasons:
+    # Do not initialize modern inputfields on selects with many entries
+    my $MaxDropdownOptions = $Kernel::OM->Get('Kernel::Config')->Get("MaxDropdownOptions");
+    $Self->AddJSData(
+        Key   => 'MaxDropdownOptions',
+        Value => $MaxDropdownOptions,
+    );
+
     return 1;
 }
 

diff --git a/var/httpd/htdocs/js/Core.UI.InputFields.js b/var/httpd/htdocs/js/Core.UI.InputFields.js
@@ -40,7 +40,6 @@ Core.UI.InputFields = (function (TargetNS) {
         ResizeEvent: 'onorientationchange' in window ? 'orientationchange' : 'resize',
         ResizeTimeout: 0,
         SafeMargin: 30,
-        MaxNumberOfOptions: 1000,
         MinQueryLength: 4,
         Diacritics: {
             "\u24B6":"A", "\uFF21":"A", "\u00C0":"A", "\u00C1":"A", "\u00C2":"A", "\u1EA6":"A",
@@ -1189,7 +1188,8 @@ Core.UI.InputFields = (function (TargetNS) {
 
             // For performance reasons:
             // Do not initialize modern inputfields on selects with many entries
-            if ($(SelectObj).children('option').length > Config.MaxNumberOfOptions) {
+            MaxDropdownOptions = Core.Config.Get('MaxDropdownOptions');
+            if ($(SelectObj).children('option').length > MaxDropdownOptions) {
                 return;
             }