Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker vulnerabilites by upgrading node image #551

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Fix docker vulnerabilites by upgrading node image #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c0473b
fix: Dockerfile to reduce vulnerabilities (#29)
joltcan Aug 20, 2024
cc79385
Do rebase outside of the make instead
joltcan Aug 20, 2024
d7da1e7
Use 22-alpine for docker
joltcan Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
FROM node:17.8-alpine3.15
FROM node:22-alpine

EXPOSE 8061

WORKDIR /iframely

# Create new non-root user
RUN addgroup -S iframelygroup && adduser -S iframely -G iframelygroup
RUN addgroup --system iframelygroup && adduser --system iframely -G iframelygroup
RUN apk add g++ make python3

# This will change the config to `config.<VALUE>.js` and the express server to change its behaviour.
Expand Down
1 change: 0 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ PUBLISHPORT := ${EXPOSEPORT}

build:
git checkout main
git pull --rebase upstream main
git branch -f tag-${VERSION}
git checkout tag-${VERSION}
docker \
Expand Down