Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen attributes stripped from Vimeo embeds #30

Closed
bdougherty opened this issue Oct 17, 2013 · 6 comments
Closed

Fullscreen attributes stripped from Vimeo embeds #30

bdougherty opened this issue Oct 17, 2013 · 6 comments
Assignees
Milestone

Comments

@bdougherty
Copy link

Vimeo embeds should contain the webkitallowfullscreen mozallowfullscreen allowfullscreen attributes so the player can go into full screen.

@iparamonau
Copy link
Member

thanks for reporting.
are you using /oembed or the one that is generated by iframely.js?

@iparamonau
Copy link
Member

also, which browser do you use? I don't have access to IE, but Chrome, Safari and FF seem to work without those parameters http://iframe.ly/bFtk

@iparamonau
Copy link
Member

Can see the issue now. Those attributes are required for flash players :\ In our tests we defaulted to html ones and could see the point of those.
Thanks for clarifying, we'll have to add it system wide, not just for Vimeo players.

While we have you Brad: would you or any other Vimeo guys be interested in helping out draft the part of Iframely embeds protocol spec, which covers the javascript/events playback? We have it intentionally left out so we can rely on experts.

The spec is at https://github.com/itteco/oembed2. Needless to say, would be amazing if Vimeo starts publishing embeds in this format too.

iparamonau added a commit that referenced this issue Oct 17, 2013
@nleush We'd need to figure out a more robust solution sime time soon.
@ghost ghost assigned iparamonau Oct 17, 2013
@bdougherty
Copy link
Author

Actually, they're required for our HTML player. Without them, we won't always be able to use the HTML player and have to fall back to Flash. Thank you for the quick fix!

I'll give the spec a closer look as soon as I get a chance. I'd definitely help out with the js part. Is there a good place to start discussions?

@iparamonau
Copy link
Member

thanks a lot. The spec has its own repository at https://github.com/itteco/oembed2. I've created an issue for playback (N1 of course :) ) - itteco/oembed2#1

PS. We would also need to learn some more about allowFullscreen. We added it system-wide as quick fix, but we would need to understand the details of cross-browser implementations to make a better choice. If you could point into a good detailed description of these attributes, I'll appreciate. Hard to find, apparently.

@bdougherty
Copy link
Author

Here's the spec, which might be the best place: http://fullscreen.spec.whatwg.org/#fullscreen-enabled-flag
Looks like MDN also mentions all three versions: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe

Basically, it just turns on the Fullscreen API inside an iframe. The only issue would be if a website owner decides that they don't want to allow embedded content to go into fullscreen, but in our experience at Vimeo, that's hardly ever the case (we've actually gotten multiple requests to automatically put videos in fullscreen when playing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants