Use TS for documentation guides #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsMapleLeaf
requested changes
Oct 29, 2023
There was a problem hiding this comment.
Ooh, thanks for this!
I updated this to merge into main, since there's no corresponding unreleased code changes with this.
Also, I forgot to mention this last time, but it's generally better to create PRs from a branch other than main, otherwise history can get confused and it's hard to include individual changes. Just a note for the future!
Only one small nit here, otherwise it looks good 👍
|
Removed useless comments and added the readme gif counter in manual tests & readme.md code example. Not sure if we need that + I have no idea how gif updates button order 🤷 |
itsMapleLeaf
requested changes
Nov 1, 2023
itsMapleLeaf
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #25.
UpdateREADME.mdto match the gif (should I?)