forked from y-crdt/ypy
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[USING, DON'T MERGE THO] Enable Lexical-style parsing #1
Open
zswaff
wants to merge
52
commits into
main
Choose a base branch
from
zack/enable-lexical-parsing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypy use XmlText rather than XmlElement for treeTask description
finish doc live syncingTask description
|
zswaff
commented
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, here are some comments. I think a lot of it is stuff you were already working on probably.
Let me know when it is ready for rereview.
I will send some more examples separately.
zswaff
changed the title
Enable Lexical parsing
[NOT READY] Enable Lexical-style parsing
May 22, 2024
…her-than-XmlElement-for-tree ypy use XmlText rather than XmlElement for tree
Revert BigInt
zswaff
changed the title
[NOT READY] Enable Lexical-style parsing
[USING, DON'T MERGE THO] Enable Lexical-style parsing
Jun 12, 2024
ahonko
reviewed
Jul 16, 2024
Update test to test for nested elements too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read about the current state of the project in this doc