Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize home page #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Optimize home page #84

wants to merge 2 commits into from

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented May 10, 2020

Change header animation to slide down using css animation, to avoid strain on the cpu.

For AnimatedTitle - move spring to within that so that its more self contained.

@oveddan oveddan requested a review from EonYang May 10, 2020 02:15
@EonYang
Copy link
Collaborator

EonYang commented May 10, 2020

Hmmm, personally I think CSS transition is dull. And it doesn't improve noticeably FPS wise.

@oveddan
Copy link
Collaborator Author

oveddan commented May 10, 2020

Css transition can be made better by just tweaking the animation type there are lots of options:
https://developer.mozilla.org/en-US/docs/Web/CSS/easing-function

On my computer it made the home page less stuttery

The issue is now when the page loads there are so many things that are happening on the cpu. We can offload this to the gpu by using a css animation.

@oveddan
Copy link
Collaborator Author

oveddan commented May 10, 2020

We don't have to do this now...lets just take more time to look at this. removing transition from the cards makes things faster. we can add transitions to cards only when they change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants