Develop #9
Merged
Develop #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging v0.1.1 from develop to master
Merging Develop
Fixed missing dplyr:: for select function to get dplyr namespace
Made changes to test_utils.R
and roxygenized the repository
… related data later
…removed tempdat.rda Next edit: Should change the testthat tests dependency from JSONs to the rda files by using data()
Model based features
Extending mhealthtools vignette
Added sensors vignette
…/philerooski/mHealthTools into check-for-errors-after-transform
Check for errors after transform functions
Include seewave dependency install instructions in README
1. All `*_features` functions have a `models` parameter for passing a list of models. 2. `transform`-like, `extract`-like and `models` parameters are assigned default values of `NULL`. 3. `*_features` functions no longer return a single dataframe, since there is now the potential to return features from both standard feature extraction functions and model based functions. Standard feature extraction (`extract`) results are stored to a named list under `extracted_features`. Model based features (`model`) are stored to the same named list under `model_features`. If an error dataframe is returned by the `transform` function, that is stored to a named list under `error`.
Models parameter propagated to all *_features functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.