Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix]: Ensure checkpointing triggers records flush to ClickHouse #156 #158

Merged
merged 1 commit into from
Dec 15, 2024
Merged

[fix]: Ensure checkpointing triggers records flush to ClickHouse #156 #158

merged 1 commit into from
Dec 15, 2024

Conversation

itinycheng
Copy link
Owner

Why are the changes needed?

Close #156.

Brief change log

  • Trigger the data flush method during checkpoint.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

czy006
czy006 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@czy006 czy006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czy006 czy006 merged commit 5f879c6 into master Dec 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czy006 czy006 czy006 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Checkpointing doesn't trigger records flush to clickhouse
2 participants
@itinycheng @czy006