Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Append the url's database and parameters to newly created connection #142 #143

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

itinycheng
Copy link
Owner

Why are the changes needed?

Close #142.

Brief change log

  • Add the options url's database and parameters to newly created connection.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@czy006 czy006 self-requested a review August 7, 2024 01:26
@czy006 czy006 merged commit 7e34551 into master Aug 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhance]: Ensure Consistency of Database and Parameters in Newly Created ClickHouse JDBC Connections
2 participants