Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon: add microsoft icon #568

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Icon: add microsoft icon #568

merged 3 commits into from
Jul 26, 2023

Conversation

shoupeva-ithaka
Copy link
Contributor

@shoupeva-ithaka shoupeva-ithaka commented Jul 26, 2023

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?
Add Microsoft icon.

How does this change work?
Added the icon to the assets and icons.json file.

Additional context
N/A

@shoupeva-ithaka shoupeva-ithaka requested a review from a team as a code owner July 26, 2023 15:59
@shoupeva-ithaka shoupeva-ithaka requested review from SMQuazi, mtorres3 and satya-achanta-venkata and removed request for a team July 26, 2023 15:59
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

🦋 Changeset detected

Latest commit: 244ff31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

size-limit report 📦

Path Size
packages/pharos/lib/index.js 47.05 KB (0%)

@daneah daneah changed the title feat(microsoft-icon): add microsoft icon Icon: add microsoft icon Jul 26, 2023
@daneah
Copy link
Member

daneah commented Jul 26, 2023

@shoupeva-ithaka you will need to remove the wrapping <svg> tag from your SVG because that is dynamically added in the code. You can run yarn lint locally to check after you've done that.

@shoupeva-ithaka
Copy link
Contributor Author

@daneah Do I merge this branch into develop and then follow the steps in the release guide? if so, it says I do not have permissions to merge the branch.

@daneah
Copy link
Member

daneah commented Jul 26, 2023

@shoupeva-ithaka you do not have permission. That is intentional. The Pharos maintainers maintain this repository.

@daneah daneah merged commit 1f17efe into develop Jul 26, 2023
8 checks passed
@daneah daneah deleted the feature/microsoft-icon branch July 26, 2023 16:48
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
sirrah-tam pushed a commit to sirrah-tam/pharos that referenced this pull request Dec 1, 2023
* feat(microsoft-icon): add microsoft icon

* docs(microsoft-icon): add changeset

* fix(microsoft-icon): remove svg tag from microsoft svg file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants