Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move custom RPC methods not covered in an EIP like wallet_sendTransaction to an odyssey_ prefixed namespace #50

Closed
zerosnacks opened this issue Oct 17, 2024 · 4 comments
Closed

Move custom RPC methods not covered in an EIP like wallet_sendTransaction to an odyssey_ prefixed namespace #50

zerosnacks opened this issue Oct 17, 2024 · 4 comments
Labels
D-good-first-issue Good for newcomers

Comments

@zerosnacks
Copy link
Member

zerosnacks commented Oct 17, 2024 •
edited
Loading

It may make sense to put Odyssey specific experimental methods first into an odyssey_* or <namespace>_odyssey_* prefixed namespace and then at a later point contribute to the EIP or draft a complementary EIP to introduce it in general namespaces like wallet_.

Example: wallet_sendTransaction is currently not part of the EIP-5792 spec
@zerosnacks zerosnacks mentioned this issue Oct 17, 2024
Merged
5 tasks
@zerosnacks zerosnacks changed the title Move custom APIs like wallet_sendTransaction to an odyssey_ prefixed namespace Move custom RPC methods not covered the EIP like wallet_sendTransaction to an odyssey_ prefixed namespace Oct 17, 2024
@zerosnacks zerosnacks changed the title Move custom RPC methods not covered the EIP like wallet_sendTransaction to an odyssey_ prefixed namespace Move custom RPC methods not covered in an EIP like wallet_sendTransaction to an odyssey_ prefixed namespace Oct 17, 2024
@onbjerg onbjerg added the D-good-first-issue Good for newcomers label Oct 17, 2024
@zerosnacks zerosnacks mentioned this issue Oct 18, 2024
Merged
@rkdud007 rkdud007 mentioned this issue Oct 18, 2024
Merged
@mahmudsudo
Copy link
Contributor

Hi ,please can i take on this ?

@jenpaff
Copy link

jenpaff commented Oct 21, 2024

i think the task is already in progress by @rkdud007

@mahmudsudo
Copy link
Contributor

Can I be assigned to another issue in its stead ?

onbjerg pushed a commit that referenced this issue Oct 23, 2024
@rkdud007
chore: odyssey_sendTransaction (#56)
db98fc9 
resolving #50 `wallet_sendTransaction` to
`wallet_odyssey_sendTransaction`

note: personally fan of `<namespace>_odyssey_*` as this contains eip's
suggestion `wallet_sendTransaction`

edit: q. saw foundry PR have alias `odyssey_sendTransaction` maybe i
should match into the one?
@onbjerg
Copy link
Member

onbjerg commented Oct 23, 2024

Closed in #56

@onbjerg onbjerg closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D-good-first-issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jenpaff @onbjerg @mahmudsudo @zerosnacks