-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Networks developed at KTH SmarTS Lab #4
Comments
More systems:
|
@lvanfretti |
@MaximeBaudette This is a major issue for the future, when I don't have any students to help me maintain the models... I don't want people to have to go through the same effort that we had to go through. |
@lvanfretti |
@MaximeBaudette |
@MaximeBaudette see the comment here |
@lvanfretti |
The Networks are being uploaded in the ApplicationExamples branch. Preliminary version of the some systems have been uploaded, I updated Luigi's comment with clickable list. When the first batch of networks has been checked and validated, it will be merged into the master branch. |
@MaximeBaudette @tinrabuzin and Ahsan you have updated and validated a lot of test systems. However, we don't provide access to validation files in the reference software. This is not part of iPSL, however, we should make them available somewhere. I suggest we figure out a way of having them available. As I don't know GIT very well, I don't know if we can have another master branch with this, but we should edit the models with an annotation of where to find them, while preserving both the Development Examples and Application Examples structure. |
@lvanfretti |
But Maxime, we should not have so much storage needed! In any case, this is really important to give people access to. We can't And finally, if I have to pay cash to get a larger Github for SmarTS Lab, Have a nice sunday! On Sun, Feb 21, 2016 at 11:35 AM, Maxime Baudette [email protected]
|
I think we should store the output results, so that we may in the future have an automatic validation of the library (I talked to Tin about Continuous Integration a while ago), and for this it would be more practical to just have all the "trace" of the models to run scripts. (It seems really unnecessary to have to "re-run all simulations", if we would have to run the check at every push) As for the source files of the reference systems, we could collect them in a separate repository... But I'm afraid we might run into the problem of copyright holders. For a lot of these systems we are not the copyright holder, and then it makes it complicated to just collect the files, while keeping it clear, what is ours, and what is somebody else's. |
@lvanfretti you can ping ahsan like this @ahsanKTH |
@MaximeBaudette @lvanfretti Here you can find an interesting way of testing the library - https://github.com/lbl-srg/modelica-buildings/wiki/Unit-Tests. I guess we could do the same with our DevelopmentExample and Application Examples... Though this doesn't solve the issue of the data storage. |
Regarding storing simulation results you might wanna have a look at https://git-lfs.github.com/ |
@dietmarw Thanks for the tip! GIT LFS looks nice. |
@tinrabuzin I don't have much experience with automatic library testing tbh. I knew about the Buildings library having some pre-release scripts in place. But you might be able to use some of the setup that OpenModelica is using for its library coverage tests. But better hear with them :-) |
We could also you something like Jenkins https://jenkins-ci.org/ which is adapted for automatic build, test, etc. You could use it to test if the latest commit is still ok and everything works after every commit or every night for example |
@petitrenaudseb Yes, I've seen Jenkins and looked into Travis, but I'm not sure how I would do it for Modelica code. |
For the ModelicaBook (which utilises OpenModelica for generation of plots etc.) @xie-dongping did recently implement a CI build using circleci (could probably be done with travis too I guess). Have a look at the setup: https://github.com/xogeny/ModelicaBook/blob/master/circle.yml which basically just launches the docker container: https://github.com/xogeny/ModelicaBook/tree/master/docker |
I am closing this item as we will not continue to support iPSL within my team. |
@tinrabuzin we need to upload the test networks we have developed over time.
There are several of them, I think some of them are already in the development examples, however, we could create under examples a folder called test networks with the network models (from what I remember, include):
Let's try to track what is available of larger test networks, and see if I forgot something.
Important
New
The text was updated successfully, but these errors were encountered: