Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve project's CSS #3760

Closed
2 of 4 tasks
julieg18 opened this issue Apr 25, 2023 · 6 comments · Fixed by #4453
Closed
2 of 4 tasks

Improve project's CSS #3760

julieg18 opened this issue Apr 25, 2023 · 6 comments · Fixed by #4453
Assignees

Comments

@julieg18
Copy link
Contributor

julieg18 commented Apr 25, 2023

Followup to #3736

@mattseddon
Copy link
Member

A couple of points I would add:

@julieg18
Copy link
Contributor Author

julieg18 commented Apr 26, 2023

Follow up on this: #3736 (comment)

Yes, that's the second third item on our task list, "Move stylelint packages into webview/node_modules instead of the root /node_modules". Though I see I've pasted the wrong comment link, I'll update it.

Add stylelint into pre-commit hook (webview/.lintstagedrc.js)

Good idea!

@mattseddon
Copy link
Member

I actually meant this:

I tried to install stylelint packages inside of webview via the stylelint.stylelintPath config option, but stylelint kept getting installed inside the root for some reason, even after moving packages inside of webview/package.json, deleting node_modules, and starting out of a fresh install. I even tried to revert yarn.lock to a previous commit and fresh install the packages but stylelint still appeared inside of /node_modules instead of /webview/node_modules. Kept the packages installed in the root for now but can revisit this later

@julieg18
Copy link
Contributor Author

julieg18 commented May 3, 2023

I actually meant this:

I tried to install stylelint packages inside of webview via the stylelint.stylelintPath config option, but stylelint kept getting installed inside the root for some reason, even after moving packages inside of webview/package.json, deleting node_modules, and starting out of a fresh install. I even tried to revert yarn.lock to a previous commit and fresh install the packages but stylelint still appeared inside of /node_modules instead of /webview/node_modules. Kept the packages installed in the root for now but can revisit this later

...Yes, that is the exact comment I'm referring too 🤔 The packages should be installed inside of /webview instead of the root since they're only used in the webview but I was having issues moving them... Is there something I'm misunderstanding?

@mattseddon
Copy link
Member

I got as far as

Yes, that's the second item on our task list

which is

Enable stylelint camelCase selector rules (#3736 (comment))

but the rest of the sentence clears everything up. Sorry.

@julieg18
Copy link
Contributor Author

julieg18 commented May 3, 2023

I got as far as

Yes, that's the second item on our task list

Whoops! I think it was the second item at the time when I wrote the comment... Or I just made a typo 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants