Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize re-rendering of plots #3334

Closed
sroy3 opened this issue Feb 22, 2023 · 1 comment · Fixed by #3348
Closed

Optimize re-rendering of plots #3334

sroy3 opened this issue Feb 22, 2023 · 1 comment · Fixed by #3348
Assignees

Comments

@sroy3
Copy link
Contributor

sroy3 commented Feb 22, 2023

There is a lot of useless re-rendering and drilling down of certain props (like the whole content of the Vega plot) that make the plots UI quite slow. It makes the resizing feature practically useless as it's almost impossible to use at times. We can definitely improve on the re-rendering to make the webview faster.

@sroy3
Copy link
Contributor Author

sroy3 commented Feb 23, 2023

Two PRs (#3337 and #3341 ) were open to optimize re-rendering. I think that there could be even more work done to optimize, but we could probably be spending an infinite amount of time on this with fewer increases in performance.

Only other thing left to close this would be cleaning up the code that update ZoomedInPlot as it's doing pretty much the same thing as the new optimization is doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant