Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to distinguish stared and un-stared exps #2540

Closed
maxagin opened this issue Oct 7, 2022 · 5 comments
Closed

Hard to distinguish stared and un-stared exps #2540

maxagin opened this issue Oct 7, 2022 · 5 comments
Assignees
Labels
A: experiments Area: experiments table webview and everything related

Comments

@maxagin
Copy link
Contributor

maxagin commented Oct 7, 2022

Also, it is hard to distinguish stared and un-stared exps (un-stared icons look too solid 🙂). Some design change is needed. - Dmitry https://www.notion.so/iterative/Dmitry-s-Codespace-talk-feedback-1e1cfb4f0ac34ba7a1daaca20c369b08#a4d2b5008b8b4fdf863b0d5d794d437b

This happened after one of the latest updates. Here is how it is supposed to look. Basically what is important, is clearly see the difference between stared and un-stared EXPs.
For some reason, I am unable to share a screenshot, so here is a link with an example https://www.figma.com/file/kTErWSdnP5PVeU6UKdx0gR/Experiments?node-id=1807%3A124133 - Maxim

Related - #2241 (comment)

@maxagin maxagin added the A: experiments Area: experiments table webview and everything related label Oct 7, 2022
@mattseddon
Copy link
Member

Feedback has been cherry-picked. This is the more general feedback on stars:

Stars - it’s a smart idea limit “labels” (in wandb and mlflow) by stars only (a single label). But I have not find it useful at all 😟 What is the expected flow? Should I use it in filters? Filters are complicated experience (in zoom-in mode, not Studio mode) - see above.

@maxagin
Copy link
Contributor Author

maxagin commented Oct 8, 2022

Here is the answer I have posted on the Notion:

Stars - it’s a smart idea limit “labels” (in wandb and mlflow) by stars only (a single label). But I have not find it useful at all 😟 What is the expected flow?...

The main purpose is to be able to mark interesting experiments so you can find them faster.

@shcheklein
Copy link
Member

I think it's a fair feedback and includes multiple things from simple (this ticket - bad style decision, hard to distinguish) to more complicated UX questions (toggle / filter only starred experiments).

My take - both things can and should be addressed. I would probably make star stand out (yellow) and grey out inactive stars. See GMail experience.

@maxagin
Copy link
Contributor Author

maxagin commented Oct 9, 2022

My two cents. The screenshot below is what we had before. The yellow - maybe (not sure we need more accent than on the screenshot)

Screen Shot 2022-10-08 at 10 01 34 PM

@shcheklein
Copy link
Member

Closed by #2604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants