Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: float banner to a side? #1937

Closed
jorgeorpinel opened this issue Jun 22, 2022 · 6 comments
Closed

readme: float banner to a side? #1937

jorgeorpinel opened this issue Jun 22, 2022 · 6 comments
Labels
A: docs Area: user documentation 🎨 design Needs design input or is being actively worked on enhancement New feature or request priority-p2 Future feature, less priority for now

Comments

@jorgeorpinel
Copy link
Contributor

So we want both a banner AND this animation this close to one another? The idea of not having to scroll to get the full value proposition can't apply. For now I put the intro paragraph above the gif...

image

TBH I'm not loving the banner as it is now (it's not horizontal): maybe we can get a square file to float on the left or right side of the title and badges?

Originally posted by @jorgeorpinel in #1816 (comment)
@jorgeorpinel jorgeorpinel added 🎨 design Needs design input or is being actively worked on A: docs Area: user documentation labels Jun 22, 2022
@jorgeorpinel
Copy link
Contributor Author

WDYT @maxagin ? Thanks

@jorgeorpinel jorgeorpinel mentioned this issue Jun 22, 2022
Merged
2 tasks
@maxagin
Copy link
Contributor

maxagin commented Jun 22, 2022

not loving the banner as it is now (it's not horizontal)

I also had this concern before. Let me see what I can do. Thank you @jorgeorpinel

@maxagin maxagin self-assigned this Jun 22, 2022
@maxagin maxagin added enhancement New feature or request priority-p1 Regular product backlog status: 🎨 design-in-progress labels Jun 22, 2022
@shcheklein
Copy link
Member

hey, folks, even if it's not perfect let's please not spend more time on this ... it's definitely not p1

@maxagin maxagin removed their assignment Jun 22, 2022
@shcheklein shcheklein added the priority-p2 Future feature, less priority for now label Jun 22, 2022
@jorgeorpinel
Copy link
Contributor Author

Agree. Some times I have to create issues for follow-ups (for example pending from merged PRs) for the team to triage/ prioritize. Lmk if that's not a productive approach. Thanks

@maxagin
Copy link
Contributor

maxagin commented Jun 23, 2022

Thank you @jorgeorpinel , follow-ups issues are important, so we can have team feedback and better understand what possibly needs to be improved. Next time we will have a good argument when discussing this matter :) and p2 is better than nothing, lol !

@shcheklein
Copy link
Member

Closing this for now. Let's do this with the next major update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: docs Area: user documentation 🎨 design Needs design input or is being actively worked on enhancement New feature or request priority-p2 Future feature, less priority for now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jorgeorpinel @shcheklein @maxagin