-
Notifications
You must be signed in to change notification settings - Fork 6
Sourcery refactored master branch #20
base: master
Are you sure you want to change the base?
Conversation
name = "test-resource" | ||
path = tmp_path / "terraform.tfstate" | ||
path.parent.mkdir(parents=True, exist_ok=True) | ||
path.write_text(TEST_RESOURCE_STATE, encoding="utf-8") | ||
yield name | ||
yield "test-resource" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function resource
refactored with the following changes:
- Inline variable that is immediately yielded (
inline-immediately-yielded-variable
) - Move assignment closer to its usage within a block (
move-assign-in-block
)
resource = { | ||
name: {key: value for key, value in config.items()}, | ||
} | ||
resource = {name: dict(config.items())} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function render_json
refactored with the following changes:
- Replace identity comprehension with call to collection constructor (
identity-comprehension
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource = { | |
name: {key: value for key, value in config.items()}, | |
} | |
resource = {name: dict(config.items())} | |
resource = {name: dict(config)} |
parser = argparse.ArgumentParser(prog="tpi") | ||
return parser | ||
return argparse.ArgumentParser(prog="tpi") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function get_main_parser
refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable
)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.35%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Branch
master
refactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
master
branch, then run:Help us improve this pull request!