Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate credentials from other environment variables #583

Merged
merged 7 commits into from
May 18, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented May 17, 2022

Closes #561 and fixes #581; not tested locally, waiting for continuous integration to complain if I “committed” some mistake.

@0x2b3bfa0 0x2b3bfa0 requested a review from a team May 17, 2022 16:22
@0x2b3bfa0 0x2b3bfa0 self-assigned this May 17, 2022
@0x2b3bfa0 0x2b3bfa0 added enhancement New feature or request cloud-aws Amazon Web Services cloud-az Microsoft Azure security Sensitive flaws cloud-gcp Google Cloud labels May 17, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 17, 2022 16:26 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 17, 2022 16:26 Inactive
@0x2b3bfa0 0x2b3bfa0 marked this pull request as draft May 17, 2022 22:37
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review May 17, 2022 23:16
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 17, 2022 23:16 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 17, 2022 23:21 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 17, 2022 23:21 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 17, 2022 23:21 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 17, 2022 23:21 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 18, 2022 00:04 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 18, 2022 00:05 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 18, 2022 00:05 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 18, 2022 00:05 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 18, 2022 01:36 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 18, 2022 01:36 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 18, 2022 01:36 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic May 18, 2022 01:36 Inactive
@dacbd
Copy link
Contributor

dacbd commented May 18, 2022

tested with:

terraform {
  required_providers { iterative = { source = "github.com/iterative/iterative" } }
}
provider "iterative" {}
resource "iterative_task" "vscode" {
  #spot      = 0
  timeout   = 24*60*60
  disk_size = 10
  machine   = "t3.small"
  image     = "ubuntu"

  # cloud-specific config
  cloud     = "aws"

  storage {
    workdir = ""
    output  = ""
  } 
  script = <<-END
    #!/bin/bash -x
    apt-get update -y && apt-get install -y ansible git
    ansible-pull --url https://github.com/dacbd/tpi-ansible.git playbook.yml
    env
    aws sts get-caller-identity
    echo "READY"
  END
}

@0x2b3bfa0 0x2b3bfa0 merged commit 5f3f581 into master May 18, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the separate-credetials branch May 18, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud-aws Amazon Web Services cloud-az Microsoft Azure cloud-gcp Google Cloud enhancement New feature or request security Sensitive flaws
Projects
None yet
Development

Successfully merging this pull request may close these issues.

canonical bin path task fix pollution of environment variables for the tpi-task.service
4 participants