Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AWS API error on us-east-1 CreateBucket #519

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Apr 20, 2022

Fixes the latest variation of the #455 nightmare, when running s3:CreateBucket on the us-east-1 region.

Error: operation error S3: CreateBucket, https response error StatusCode: 400, RequestID: ..., HostID: ..., api error MalformedXML: The XML you provided was not well-formed or did not validate against our published schema

When running PUT https://{bucket}.s3.us-east-1.amazonaws.com with no options, the request body should be empty, like in Content-Lenght: 0 empty.

Before this pull request, the body had an empty XML document:

<CreateBucketConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/"></CreateBucketConfiguration>

@0x2b3bfa0 0x2b3bfa0 requested a review from a team April 20, 2022 15:51
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic April 20, 2022 15:51 Inactive
@0x2b3bfa0 0x2b3bfa0 self-assigned this Apr 20, 2022
@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working p0-critical Max priority (ASAP) cloud-aws Amazon Web Services resource-task iterative_task TF resource labels Apr 20, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic April 20, 2022 15:57 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic April 20, 2022 15:57 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic April 20, 2022 15:57 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic April 20, 2022 15:57 Inactive
@casperdcl
Copy link
Contributor

casperdcl commented Apr 20, 2022

(re) fixes #454 (or at least the us-east bit).

Should we add e2e us-east tests to catch this? Seems us-east can be a bit cheaper than us-west (by ~20% on g4dn.xlarge for example)

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Apr 20, 2022

This pull request doesn't fix that issue, it fixes a different issue that happens when performing the same action. Anyway, I feel nitpicky today. 😄

@0x2b3bfa0
Copy link
Member Author

Should we add tests to catch this?

We can move our tests to us-east-1 but they're going to be slower. 🤷🏼‍♂️ I hope that this time we fix the issue for real.

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic April 20, 2022 16:40 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic April 20, 2022 16:40 Inactive
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested; working thx

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic April 20, 2022 16:40 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic April 20, 2022 16:40 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic April 20, 2022 16:40 Inactive
@0x2b3bfa0 0x2b3bfa0 merged commit 15516e2 into master Apr 20, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the torvalds-nvidia-aws branch April 20, 2022 16:49
casperdcl added a commit to iterative/blog-tpi-jupyter that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cloud-aws Amazon Web Services p0-critical Max priority (ASAP) resource-task iterative_task TF resource
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants