-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AWS API error on us-east-1 CreateBucket #519
Conversation
(re) fixes #454 (or at least the Should we add e2e |
This pull request doesn't fix that issue, it fixes a different issue that happens when performing the same action. Anyway, I feel nitpicky today. 😄 |
We can move our tests to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested; working thx
Fixes the latest variation of the #455 nightmare, when running
s3:CreateBucket
on theus-east-1
region.When running
PUT https://{bucket}.s3.us-east-1.amazonaws.com
with no options, the request body should be empty, like inContent-Lenght: 0
empty.Before this pull request, the body had an empty XML document: