-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support compopt in completion functions (Sourcery refactored) #79
Conversation
Sourcery Code Quality ReportMerging this PR leaves code quality unchanged.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
- Coverage 91.04% 90.99% -0.06%
==========================================
Files 3 3
Lines 335 333 -2
==========================================
- Hits 305 303 -2
Misses 30 30
Continue to review full report at Codecov.
|
030ec20
to
0a964b3
Compare
@0x2b3bfa0 - what's the history and current approach behind sourcery-ai bot? |
I believe @casperdcl enabled this in September 2021, but don't have any additional context. Not sure if it's worth the noise, albeit the f-strings suggestion on this pull request was nice. 🤷♂️ |
@0x2b3bfa0 - opened #135 in your honour. 🧹 🧹 🧹 |
Pull Request #78 refactored by Sourcery.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Help us improve this pull request!