Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next release v1.3.0 #19

Merged
merged 17 commits into from
Aug 4, 2020
Merged

next release v1.3.0 #19

merged 17 commits into from
Aug 4, 2020

Conversation

casperdcl
Copy link
Collaborator

@casperdcl casperdcl commented Aug 1, 2020

  • fix bash missing custom complete functionality (add_argument().complete = ...)
  • fix subcommand completion & update examples/customcomplete.py
  • expose SUPPORTED_SHELLS
  • add shtab.add_argument_to(parser, option_string) (add convenience functions #18)
    • option: adds your_cli_app [--print-completion={bash,zsh}]
    • subcommand: adds your_cli_app completion [{bash,zsh}]
    • handles the print(shtab.complete(parser, shell)) & exit(0) logic too
  • add & update documentation
  • add tests
  • misc tidy

@casperdcl casperdcl changed the title Devel next release v1.3.0 Aug 1, 2020
@casperdcl casperdcl self-assigned this Aug 1, 2020
@casperdcl casperdcl added documentation Markdown files enhancement New feature or request labels Aug 1, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2020

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   86.84%   86.84%           
=======================================
  Files           1        1           
  Lines          38       38           
=======================================
  Hits           33       33           
  Misses          5        5           
Impacted Files Coverage Δ
shtab/main.py 86.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82cf362...3018fc7. Read the comment docs.

@mpkocher
Copy link

mpkocher commented Aug 1, 2020

add_argument_to should probably be exported to __all__. Also, it might be useful to update the README to be explicit that shtab can be used a library, not just from the command line.

Thanks for shepherding this feature request!

shtab/__init__.py Outdated Show resolved Hide resolved
@casperdcl casperdcl merged commit 67be753 into master Aug 4, 2020
@casperdcl casperdcl deleted the devel branch August 4, 2020 20:05
@casperdcl
Copy link
Collaborator Author

/tag v1.3.0 67be753

casperdcl added a commit to casperdcl/dvc that referenced this pull request Aug 4, 2020
Depends on iterative/shtab#19
Fixes bash not completing filenames & dirs
efiop pushed a commit to iterative/dvc that referenced this pull request Aug 6, 2020
Depends on iterative/shtab#19
Fixes bash not completing filenames & dirs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Markdown files enhancement New feature or request shell-bash shell-zsh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add convenience functions
3 participants