Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create v2 #94

Merged
merged 18 commits into from
Sep 28, 2023
Merged

Create v2 #94

merged 18 commits into from
Sep 28, 2023

Conversation

dacbd
Copy link
Contributor

@dacbd dacbd commented Sep 27, 2023 •
edited
Loading

few things of note:

  • uses cml prebuilt binaries
  • uses github actions tool cache

@dacbd dacbd changed the base branch from v1 to v2 September 27, 2023 19:29
@dacbd dacbd marked this pull request as ready for review September 27, 2023 19:36
@github-actions
Copy link

Hello CML from ubuntu-latest!

@github-actions
Copy link

Hello CML from macos-latest!

@iterative iterative deleted a comment from github-actions bot Sep 27, 2023
@iterative iterative deleted a comment from github-actions bot Sep 27, 2023
@iterative iterative deleted a comment from github-actions bot Sep 27, 2023
@iterative iterative deleted a comment from github-actions bot Sep 27, 2023
@iterative iterative deleted a comment from github-actions bot Sep 27, 2023
@iterative iterative deleted a comment from github-actions bot Sep 27, 2023
@iterative iterative deleted a comment from github-actions bot Sep 27, 2023
@iterative iterative deleted a comment from github-actions bot Sep 27, 2023
@iterative iterative deleted a comment from github-actions bot Sep 27, 2023
@iterative iterative deleted a comment from github-actions bot Sep 27, 2023
@iterative iterative deleted a comment from github-actions bot Sep 27, 2023
@iterative iterative deleted a comment from github-actions bot Sep 27, 2023
@iterative iterative deleted a comment from github-actions bot Sep 27, 2023
@iterative iterative deleted a comment from github-actions bot Sep 27, 2023
@dacbd dacbd self-assigned this Sep 27, 2023
@dacbd dacbd requested a review from a team September 27, 2023 19:46
0x2b3bfa0
0x2b3bfa0 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome to me!
(Provided it works)

Is there any reason to consider this an inherently breaking change and bump the major version?

@dacbd
Copy link
Contributor Author

dacbd commented Sep 28, 2023

Yes, there are a few things I would consider breaking, removing the force and sudo options.

Using the tool cache and the cml binary build are features enough that I would consider them worthy of a major feature bump, while not breaking there are certain versions that it won't work with so it is not fully backward compatible in that way.

@dacbd dacbd merged commit f714cd2 into v2 Sep 28, 2023
8 checks passed
@dacbd dacbd deleted the v2-setup branch September 28, 2023 06:34
@github-actions
Copy link

Hello CML from ubuntu-latest!

1 similar comment
@github-actions
Copy link

Hello CML from ubuntu-latest!

@github-actions
Copy link

Hello CML from macos-latest!

@github-actions
Copy link

Hello CML from windows-latest!

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Hello CML from ubuntu-latest!

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Hello CML from macos-latest!

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Hello CML from windows-latest!

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Hello CML from ubuntu-latest!

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Hello CML from macos-latest!

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Hello CML from windows-latest!

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Hello CML from ubuntu-latest!

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Hello CML from macos-latest!

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Hello CML from windows-latest!

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Hello CML from ubuntu-latest!

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Hello CML from macos-latest!

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Hello CML from windows-latest!

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Hello CML from ubuntu-latest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

Assignees

@dacbd dacbd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dacbd @0x2b3bfa0