Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pygit2: bump to 1.14.0 #312

Merged
merged 7 commits into from
Jan 28, 2024
Merged

pygit2: bump to 1.14.0 #312

merged 7 commits into from
Jan 28, 2024

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 added maintenance pygit2 Related to pygit2 backend labels Jan 28, 2024
@0x2b3bfa0 0x2b3bfa0 requested a review from a team January 28, 2024 15:35
@0x2b3bfa0 0x2b3bfa0 self-assigned this Jan 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (6e44250) 77.44% compared to head (649a130) 78.35%.

Files Patch % Lines
src/scmrepo/git/lfs/client.py 50.00% 2 Missing ⚠️
src/scmrepo/git/lfs/object.py 0.00% 2 Missing ⚠️
src/scmrepo/git/lfs/fetch.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   77.44%   78.35%   +0.91%     
==========================================
  Files          39       39              
  Lines        4969     4980      +11     
  Branches      897      897              
==========================================
+ Hits         3848     3902      +54     
+ Misses        967      924      -43     
  Partials      154      154

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop
Copy link
Contributor

efiop commented Jan 28, 2024

We need to drop 3.8 first, will do in a separate PR in a sec...

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Jan 28, 2024 •
edited
Loading

@efiop, shall I revert 3095ebc then? :fastpoke:

@efiop
Copy link
Contributor

efiop commented Jan 28, 2024

@0x2b3bfa0 Nah, let's keep it then.

efiop
efiop previously approved these changes Jan 28, 2024
View reviewed changes
@efiop efiop mentioned this pull request Jan 28, 2024
Closed
efiop
efiop previously approved these changes Jan 28, 2024
View reviewed changes
efiop
efiop previously approved these changes Jan 28, 2024
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:fastpoke: Thanks for adding 3.12 as well! 🙏

shcheklein
shcheklein previously approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @0x2b3bfa0 !

@0x2b3bfa0 0x2b3bfa0 dismissed stale reviews from shcheklein and efiop via 649a130 January 28, 2024 16:22
@0x2b3bfa0
Copy link
Member Author

Ubuntu on Python 3.9 was failing (run); hoping to get it fixed with 649a130

efiop
efiop approved these changes Jan 28, 2024
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @0x2b3bfa0 !

@efiop efiop merged commit 0d23565 into main Jan 28, 2024
13 checks passed
@efiop efiop deleted the 0x2b3bfa0-patch-1 branch January 28, 2024 16:30
@skshetry skshetry mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiop efiop efiop approved these changes

@shcheklein shcheklein shcheklein left review comments

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
maintenance pygit2 Related to pygit2 backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0x2b3bfa0 @codecov-commenter @efiop @shcheklein