return ls as internal API #477
Conversation
|
Wow, do you have any idea why CI didn't run? 🤔 |
|
No idea |
Codecov ReportBase: 60.01% // Head: 87.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
===========================================
+ Coverage 60.01% 87.31% +27.29%
===========================================
Files 95 96 +1
Lines 8135 8141 +6
===========================================
+ Hits 4882 7108 +2226
+ Misses 3253 1033 -2220
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| and parent != MlemObject | ||
| and issubclass(parent, MlemObject) | ||
| ): | ||
| type_ = parent |
There was a problem hiding this comment.
Can this be folded into a MlemObject method meta.get_mlem_type() that handles links/non links?
or does this not generalize well enough?
There was a problem hiding this comment.
Dont recall any other places with such logic.
So we can have
- a link - we put it into whatever it links to
- a non-polymorphic object, which goes to it's type bucket
- a polymorphic object, which goes to it's parent type bucket
There was a problem hiding this comment.
I understand, just feels like messing with the classes' internals. So this type resolution is only specific to the ls implementation today?
There was a problem hiding this comment.
So this type resolution is only specific to the ls implementation today?
Yes.
close #478