Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Add links to deployment env declare #440

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Conversation

mike0sv
Copy link
Contributor

@mike0sv mike0sv commented Oct 16, 2022

and some other fixes from #397 comments

@mike0sv mike0sv requested a review from a team October 16, 2022 12:57
@mike0sv mike0sv temporarily deployed to internal October 16, 2022 12:57 Inactive
@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Base: 87.62% // Head: 86.82% // Decreases project coverage by -0.80% ⚠️

Coverage data is based on head (6fc99c9) compared to base (d60f3cf).
Patch coverage: 70.93% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/0.3.0     #440      +/-   ##
=================================================
- Coverage          87.62%   86.82%   -0.81%     
=================================================
  Files                 94       94              
  Lines               7847     7879      +32     
=================================================
- Hits                6876     6841      -35     
- Misses               971     1038      +67     
Impacted Files Coverage Δ
mlem/cli/apply.py 94.23% <ø> (ø)
mlem/cli/build.py 100.00% <ø> (ø)
mlem/cli/checkenv.py 100.00% <ø> (ø)
mlem/cli/clone.py 100.00% <ø> (ø)
mlem/cli/config.py 95.55% <ø> (ø)
mlem/cli/dev.py 50.00% <ø> (ø)
mlem/cli/import_object.py 100.00% <ø> (ø)
mlem/cli/info.py 97.56% <ø> (ø)
mlem/cli/init.py 100.00% <ø> (ø)
mlem/cli/link.py 100.00% <ø> (ø)
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mike0sv mike0sv temporarily deployed to internal October 16, 2022 15:42 Inactive
Copy link
Contributor

@aguschin aguschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aguschin aguschin merged commit b7b6879 into release/0.3.0 Oct 17, 2022
@aguschin aguschin deleted the fix/release3-comments branch October 17, 2022 04:27
@mike0sv mike0sv temporarily deployed to internal October 17, 2022 10:16 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants