Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

fix issues with pandas pylint and flake8 #427

Merged
merged 5 commits into from
Oct 3, 2022
Merged

Conversation

madhur-tandon
Copy link
Contributor

No description provided.

@madhur-tandon madhur-tandon requested a review from a team October 3, 2022 12:44
@madhur-tandon madhur-tandon temporarily deployed to internal October 3, 2022 12:44 Inactive
@madhur-tandon madhur-tandon self-assigned this Oct 3, 2022
@mike0sv mike0sv temporarily deployed to internal October 3, 2022 14:18 Inactive
@mike0sv mike0sv temporarily deployed to internal October 3, 2022 14:22 Inactive
@mike0sv mike0sv temporarily deployed to internal October 3, 2022 14:22 Inactive
@mike0sv mike0sv temporarily deployed to internal October 3, 2022 14:36 Inactive
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 89.39% // Head: 87.64% // Decreases project coverage by -1.75% ⚠️

Coverage data is based on head (7613c10) compared to base (51f328a).
Patch coverage: 94.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   89.39%   87.64%   -1.76%     
==========================================
  Files          81       81              
  Lines        6376     6386      +10     
==========================================
- Hits         5700     5597     -103     
- Misses        676      789     +113     
Impacted Files Coverage Δ
mlem/cli/main.py 68.58% <75.00%> (+3.09%) ⬆️
mlem/contrib/pandas.py 93.10% <100.00%> (ø)
mlem/ui.py 85.13% <100.00%> (-7.62%) ⬇️
mlem/utils/module.py 88.51% <100.00%> (-1.60%) ⬇️
mlem/utils/backport.py 10.25% <0.00%> (-64.11%) ⬇️
mlem/contrib/docker/helpers.py 50.00% <0.00%> (-50.00%) ⬇️
mlem/contrib/heroku/utils.py 39.34% <0.00%> (-40.99%) ⬇️
mlem/contrib/heroku/build.py 55.17% <0.00%> (-34.49%) ⬇️
mlem/contrib/heroku/meta.py 52.00% <0.00%> (-32.00%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mike0sv mike0sv temporarily deployed to internal October 3, 2022 14:54 Inactive
@mike0sv mike0sv temporarily deployed to internal October 3, 2022 15:18 Inactive
@madhur-tandon madhur-tandon merged commit 779b8b3 into main Oct 3, 2022
@madhur-tandon madhur-tandon deleted the fix/linting_and_reqs branch October 3, 2022 15:43
aguschin pushed a commit that referenced this pull request Oct 5, 2022
* fix issues with pandas pylint and flake8

* fix requirements

* fix req tests

* remove comment

* fix catboost req tests

Co-authored-by: mike0sv <[email protected]>
aguschin added a commit that referenced this pull request Oct 5, 2022
* initial draft

* almost

* fixing things

* fix bug

* fix links in config get/set

* mark test as long

* remove newline characters, add help to mlemmixin

* fix linting

* fix some tests

* mark test as xfail

* fix issues with pandas pylint and flake8 (#427)

* fix issues with pandas pylint and flake8

* fix requirements

* fix req tests

* remove comment

* fix catboost req tests

Co-authored-by: mike0sv <[email protected]>

Co-authored-by: mike0sv <[email protected]>
Co-authored-by: Madhur Tandon <[email protected]>
mike0sv added a commit that referenced this pull request Oct 5, 2022
* refactoring of deployments and env - move logic to deployments, remove model field

* adjust deployments cli

* add rev to deploy API

* fix tests and pylint

* add deployment declaration and model link to state

* fix lint

* fix tests

* fix tests

* fix tests

* add debug env

* fix crash on missing deps

* linting

* fix issues with pandas pylint and flake8

* fix requirements

* fix req tests

* remove comment

* fix docker tests

* fix catboost req tests

* fix issues with pandas pylint and flake8 (#427)

* fix issues with pandas pylint and flake8

* fix requirements

* fix req tests

* remove comment

* fix catboost req tests

Co-authored-by: mike0sv <[email protected]>

* fix k8s tests

* fix k8s tests

* fix windows bugs

* fix sagemaker circular import

* fix configs

* Apply suggestions from code review

Co-authored-by: Alexander Guschin <[email protected]>

* Update mlem/cli/deployment.py

Co-authored-by: Alexander Guschin <[email protected]>

Co-authored-by: Madhur Tandon <[email protected]>
Co-authored-by: Madhur Tandon <[email protected]>
Co-authored-by: Alexander Guschin <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants