This repository has been archived by the owner on Sep 13, 2023. It is now read-only.
Sagemaker deployments #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # mlem/contrib/docker/base.py
Codecov Report
@@ Coverage Diff @@
## feature/new-state #366 +/- ##
====================================================
Coverage ? 87.03%
====================================================
Files ? 86
Lines ? 6973
Branches ? 0
====================================================
Hits ? 6069
Misses ? 904
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mike0sv
added a commit
that referenced
this pull request
Sep 14, 2022
* new state POC * update docker and mock deployments * add locks * simplify deployment meta (by complexifying code) * fix tests * fix tests * fix tests * fix win tests * default env and server * fsspec manager as default * Sagemaker deployments (#366) * WIP * its alive (kinda) * it works but it's ugly * little less ugly * lil fix * fix lint * fix lint * fix tests * fix tests * fix windows bugs * fix tests * fix tests * fix for dirs deployment state * create MlemSource to choose how mlem is added to docker * test that all configs in entrypoints * better cli val error * better docker package install * finish merge * fix short tests * fix short tests * Update mlem/contrib/sagemaker/runtime.py Co-authored-by: Alexander Guschin <[email protected]> * Update mlem/core/objects.py Co-authored-by: Alexander Guschin <[email protected]> * Update mlem/core/objects.py Co-authored-by: Alexander Guschin <[email protected]> * Update mlem/contrib/docker/base.py Co-authored-by: Alexander Guschin <[email protected]> * Update mlem/contrib/docker/base.py Co-authored-by: Alexander Guschin <[email protected]> * Update mlem/contrib/docker/base.py Co-authored-by: Alexander Guschin <[email protected]> * Update mlem/contrib/heroku/meta.py Co-authored-by: Alexander Guschin <[email protected]> * Apply suggestions from code review Co-authored-by: Alexander Guschin <[email protected]> * Update mlem/contrib/sagemaker/build.py Co-authored-by: Alexander Guschin <[email protected]> Co-authored-by: Alexander Guschin <[email protected]>
madhur-tandon
pushed a commit
that referenced
this pull request
Sep 14, 2022
* WIP * its alive (kinda) * it works but it's ugly * little less ugly * lil fix * fix lint * fix lint * fix tests * fix tests * fix windows bugs * fix tests * fix tests
mike0sv
added a commit
that referenced
this pull request
Sep 15, 2022
* fix tests * Sagemaker deployments (#366) * WIP * its alive (kinda) * it works but it's ugly * little less ugly * lil fix * fix lint * fix lint * fix tests * fix tests * fix windows bugs * fix tests * fix tests * test that all configs in entrypoints * fix short tests * wip kubernetes support * use APIs to deploy and get status, deletion still pending * remove get client from state * fix param * fix jinja template * working remove and status * fix client * small fixes * attempt to add tests * setup github actions for k8s tests * fix linter * use predict method of client * allow registry to be configurable by cli * change calculation of host and port according to service type * re-enable k8s test as new workflow * fix daemon access in tests * make linter happy * fix fixtures * suggested fixes and refactor * make namespace as a separate field and use enums * use watcher to figure out when resources are deleted * check minikube status before loading kubeconfig in fixture * minor suggestions * use enums for comparisons as well * create abstract class for services for host and port info * raise error when service of type clusterIP * fix build and use tag as model hash * fix echo message * hot swapping of docker image deployed * remove unnecessary f-string * skip swapping when same hash is tried to be deployed again * suggested improvements * fix lint * fix pylint * suggested improvements * fix pylint * update entrypoints * add docstrings for K8sYamlBuildArgs * add docstrings for k8s service type classes * capitalize docstrings for fields * remove service type enum * Remove new workflow for K8s * remove duplicate methods * remove version from iterative-telemetry Co-authored-by: mike0sv <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.