Get default branch from deployment event #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperdcl
approved these changes
Jul 29, 2022
| description: "The main branch of this repository" | ||
| default: "main" | ||
| description: "The branch to compare against when finding new links to check" | ||
| default: "${{ github.event.repository.default_branch }}" |
There was a problem hiding this comment.
surprised that this is accessible from on.workflow_call.inputs.<inputs_id>.default but according to https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability this should actually work fine :)
There was a problem hiding this comment.
I was skeptical at first as well and was ready to just axe the option, but I made sure to test this out first and it surprisingly went just fine.
…tect-diff-branch-in-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR utilizes the
default_branchgiven to us by GitHub to populate thebranch(previouslymain) field when getting diffs.The ability to override the branch is kept because it was easy and could be useful in some cases, but in most cases users won't need it.
Test branch at iterative/cml.dev#287