Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools global highlighter #12

Merged
merged 2 commits into from
May 19, 2022
Merged

Tools global highlighter #12

merged 2 commits into from
May 19, 2022

Conversation

yathomasi
Copy link
Contributor

  • Supporting mlem commands
  • Generic language cli for highlighting dvc, cml, mlem
  • dvc still works(only dvc) and can be thought of as alias to cli
    • keeping it so it wouldn't break dvc.org

@yathomasi yathomasi mentioned this pull request May 19, 2022
Closed
@yathomasi yathomasi marked this pull request as ready for review May 19, 2022 16:06
@yathomasi yathomasi requested a review from a team May 19, 2022 16:06
@rogermparent rogermparent merged commit 508b8c2 into main May 19, 2022
@casperdcl
Copy link
Contributor

casperdcl commented May 20, 2022 •
edited
Loading

What about git? To me it's part of the dvc/cml/mlem group.

@casperdcl casperdcl mentioned this pull request May 20, 2022
Closed
@shcheklein
Copy link
Member

shcheklein commented May 20, 2022 •
edited
Loading

git is already handled by the current syntax highlighter (dvc) - so, we should be good, right?

https://dvc.org/doc/start/data-management

@rogermparent rogermparent mentioned this pull request May 23, 2022
Merged
1 task
@casperdcl casperdcl deleted the tools-global-highlighter branch June 7, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogermparent rogermparent rogermparent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yathomasi @casperdcl @shcheklein @rogermparent