Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reqs, fix TF bug #5

Merged
merged 3 commits into from
Nov 1, 2019
Merged

Update reqs, fix TF bug #5

merged 3 commits into from
Nov 1, 2019

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Nov 1, 2019 •
edited by jorgeorpinel
Loading

fixes #3

  • update to tensorflow==2
  • add missing scipy dependency
  • fix metrics by using CSVLogger
  • neaten progress with tqdm
  • soft-pin dependencies on major version
  • correct README.md link to documentation

TODO

After merge, update https://dvc.org/doc/tutorials/versioning to use metrics.csv rather than metrics.json

@casperdcl casperdcl added bug Something isn't working enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 1, 2019
@casperdcl casperdcl self-assigned this Nov 1, 2019
@casperdcl casperdcl mentioned this pull request Nov 1, 2019
Closed
jorgeorpinel
jorgeorpinel suggested changes Nov 1, 2019
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
jorgeorpinel
jorgeorpinel reviewed Nov 1, 2019
View reviewed changes
README.md Show resolved Hide resolved
jorgeorpinel
jorgeorpinel approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Nice addition about tqdm!

shcheklein
shcheklein approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but looks great. @jorgeorpinel how about speed this time?

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Nov 1, 2019 •
edited
Loading

Just pending:

I'll address this myself 🙂

@jorgeorpinel jorgeorpinel changed the title Update req Update reqs, fix TF bug Nov 1, 2019
@shcheklein
Copy link
Member

@jorgeorpinel feel free to merge it you feel it's done!

@casperdcl good stuff! thanks!

@jorgeorpinel
Copy link
Contributor

how about speed this time?

Still a few minutes, maybe under 10 though. Drained 4% of my battery too haha. Seems reasonable to me. The tutorial runs this 3 times though.

jorgeorpinel added a commit to iterative/dvc.org that referenced this pull request Nov 1, 2019
@jorgeorpinel
tutorials: metrics.json -> metrics.csv
263bdb8 
per iterative/example-versioning#5 (comment)
@jorgeorpinel jorgeorpinel merged commit 8ab852d into iterative:master Nov 1, 2019
@jorgeorpinel jorgeorpinel mentioned this pull request Nov 1, 2019
Merged
@casperdcl casperdcl deleted the update-req branch November 1, 2019 02:31
@casperdcl casperdcl mentioned this pull request Nov 1, 2019
Closed
@casperdcl casperdcl mentioned this pull request Nov 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein approved these changes

@jorgeorpinel jorgeorpinel jorgeorpinel approved these changes

Assignees

@casperdcl casperdcl

Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update code requirements, fix train.py
3 participants
@casperdcl @jorgeorpinel @shcheklein