Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dataset-registry? #8

Closed
jorgeorpinel opened this issue Aug 26, 2019 · 3 comments · Fixed by #9
Closed

Remove dataset-registry? #8

jorgeorpinel opened this issue Aug 26, 2019 · 3 comments · Fixed by #9

Comments

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Aug 26, 2019

I think the point of generating https://github.com/iterative/example-get-started from a script in this repo was that there are different steps that loosely follow the actual Get Started section of the dvc.org docs. Each step corresponds to a Git commit and tag.

After merging PR #7 I realized that actually https://github.com/iterative/dataset-registry doesn't really needs steps. All the datasets could just be added in a single commit. So that repo could just be maintained manually instead of having to edit the script here and overwrite it every time. What do you think @shcheklein?

There should be other repos that may be better fit to be generated from this project though, e.g. as described in iterative/dvc.org#487 (comment).

@shcheklein
Copy link
Member

good points, @jorgeorpinel . I may be even more beneficial to support it manually. We will be able to see the evolution of the different datasets. So, feel free to go this path and resolve when you remove the script?

jorgeorpinel added a commit to iterative/dataset-registry that referenced this issue Aug 28, 2019
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Aug 28, 2019

Done. And ye, we can now see the evolution of the datasets registry. For example my latest commit adds the example-versioning datasets: iterative/dataset-registry@5f29775

@shcheklein
Copy link
Member

this is awesome @jorgeorpinel . Great point about creating and managing it separately.

casperdcl pushed a commit that referenced this issue Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants