bump mypy, fixing tests and deps #832
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [mypy](https://github.com/python/mypy) from 1.10.0 to 1.10.1. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.10.0...v1.10.1) --- updated-dependencies: - dependency-name: mypy dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
| @@ -13,7 +12,7 @@ | |||
| "uint32", | |||
| "uint64", | |||
| ] | |||
| NUMPY_FLOATS = ["float_", "float16", "float32", "float64"] | |||
There was a problem hiding this comment.
Tests were failing due to numpy 2.0.
This solves this. And from what I can tell we don't need those types, they are not actual classes. so the check like:
o.__class__.__name__ in NUMPY_INTS (and the only way we are using it)
won't be successful.
|
I'm also going to drop catalyst, I think the project is not active anymore and it looks like it's causing some issues cc @dberenbaum @skshetry |
shcheklein
force-pushed
the
dependabot/pip/mypy-1.10.1
branch
2 times, most recently
from
80ae32d to
3b1606a
Compare
shcheklein
force-pushed
the
dependabot/pip/mypy-1.10.1
branch
from
3b1606a to
9ea9f75
Compare
| @@ -173,7 +173,7 @@ def test_huggingface_log_model( | |||
| trainer.train() | |||
|
|
|||
| expected_call_count = { | |||
| "all": 2, | |||
| "all": 3, | |||
There was a problem hiding this comment.
@dberenbaum when you have a minute - for some reason there are more calls. I suspect that removing catalyst made it run with the recent version of the HF transformers. 3 calls come from them, AFAIU we don't control it much>
|
@dberenbaum could you please take a look when you have a minute. Thanks. |
|
@dberenbaum are we good to merge this? :) |
Let's make sure to update the docs. Should we do a major version bump? |
|
Sorry for the delay here. Let me take a look into some of these more deeply and I'll get back with a final review. |
shcheklein
changed the title
|
@dberenbaum let me know if everything else looks good and we can merge. Thanks!. |
Bumps mypy from 1.10.0 to 1.10.1.
Changelog
Sourced from mypy's changelog.
... (truncated)
Commits
c28b525[1.10 backport] Fix error reporting on cached run after uninstallation of thi...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)