custom exp name #725
Merged
custom exp name #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
dberenbaum
commented
Oct 18, 2023
| @@ -62,6 +62,7 @@ def __init__( # noqa: PLR0913 | |||
| save_dvc_exp: bool = False, | |||
| dvcyaml: bool = True, | |||
| cache_images: bool = False, | |||
| exp_name: Optional[str] = None, | |||
There was a problem hiding this comment.
Will add exp_message and update other args for this callback in a separate PR.
shcheklein
reviewed
Oct 18, 2023
shcheklein
reviewed
Oct 19, 2023
| if name: | ||
| ref = ExpRefInfo(baseline_sha=baseline_rev, name=name) | ||
| if scm.get_ref(str(ref)): | ||
| logger.warning(f"Experiment conflicts with existing experiment '{name}'.") |
There was a problem hiding this comment.
btw., what happens if two people name the experiment the same way simultaneously (feels that it would have been better to have still some random id / hash in the name or something).
There was a problem hiding this comment.
Nothing prevents us from adding a random suffix, but it's outside the scope of this PR, right? How about we open an issue in dvc to discuss it?
There was a problem hiding this comment.
yep, sorry, not a blocker for this PR
shcheklein
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #582