Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live: warn when DVC_ROOT is set but DVC_EXP_BASELINE_REV is not #702

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Sep 6, 2023

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Will close #670 (requires iterative/dvc#9879)

  • Generates a warning message when dvclive is init'ed inside a dvc repro pipeline stage (but not when inside dvc exp run)

With https://github.com/iterative/lstm_seq2seq:

$ dvc repro
Running stage 'download':
...
Running stage 'train':
> python train.py
Number of samples: 10000
Number of unique input tokens: 72
Number of unique output tokens: 101
Max sequence length for inputs: 117
Max sequence length for outputs: 149
WARNING:dvclive:Some DVCLive features are unsupported in `dvc repro`.
To use DVCLive with a DVC Pipeline, run it with `dvc exp run`.
GPU available: True (mps), used: True
TPU available: False, using: 0 TPU cores
IPU available: False, using: 0 IPUs
HPU available: False, using: 0 HPUs
...

@pmrowla pmrowla self-assigned this Sep 6, 2023
@pmrowla pmrowla requested review from daavoo and dberenbaum September 6, 2023 06:35
@codecov-commenter
Copy link

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/dvclive/live.py 100.00%

πŸ“’ Thoughts on this report? Let us know!.

@daavoo daavoo added the A: dvc DVC integration label Sep 7, 2023
@daavoo daavoo merged commit 9167a49 into iterative:main Sep 20, 2023
@pmrowla pmrowla deleted the repro-dvc-root branch September 20, 2023 10:07
@shcheklein
Copy link
Member

I feel we overdid this a bit. I'm not sure why it should be showing a warning if I don't even want to save experiments. Are we completely deprecating dvc repro this way? cc @dberenbaum

@dberenbaum
Copy link
Collaborator

I see I had a similar concern back when we introduced it. I don't see why we need two different messages here either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: dvc DVC integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warn on repro usage
5 participants