fix(experiments): use custom Random gen in exp names
#576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 43 43
Lines 2871 2872 +1
Branches 240 240
=======================================
+ Hits 2761 2762 +1
Misses 65 65
Partials 45 45
☔ View full report in Codecov by Sentry. |
daavoo
approved these changes
May 22, 2023
Actually, we now have DVC as explicit dependency, we should remove this code and import the function from there |
daavoo
added a commit
to iterative/dvc
that referenced
this pull request
May 22, 2023
See iterative/dvclive#576 Co-authored-by: Ivan Shcheklein <[email protected]>
daavoo
added a commit
to iterative/dvc
that referenced
this pull request
May 22, 2023
See iterative/dvclive#576 Co-authored-by: Ivan Shcheklein <[email protected]>
|
Closing in favor of the DVC one and will bump version and import here |
daavoo
added a commit
to iterative/dvc
that referenced
this pull request
May 22, 2023
See iterative/dvclive#576 Co-authored-by: Ivan Shcheklein <[email protected]>
daavoo
added a commit
to iterative/dvc
that referenced
this pull request
May 22, 2023
See iterative/dvclive#576 Co-authored-by: Ivan Shcheklein <[email protected]>
mergify bot
pushed a commit
to iterative/dvc
that referenced
this pull request
May 22, 2023
See iterative/dvclive#576 Co-authored-by: Ivan Shcheklein <[email protected]> (cherry picked from commit eb45cda)
mergify bot
pushed a commit
to iterative/dvc
that referenced
this pull request
May 22, 2023
See iterative/dvclive#576 Co-authored-by: Ivan Shcheklein <[email protected]> (cherry picked from commit eb45cda)
skshetry
pushed a commit
to iterative/dvc
that referenced
this pull request
May 22, 2023
…9491) get_random_exp_name: Use custom random generator. See iterative/dvclive#576 Co-authored-by: Ivan Shcheklein <[email protected]> (cherry picked from commit eb45cda) Co-authored-by: daavoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common in ML frameworks to have seed set for reproducibility. I don't think we want this for experiment names though. It creates collisions, which is fine by itself, but in this case can be extreme.
If this approach sounds good, I'll fix it in DVC also.
Screen.Recording.2023-05-21.at.3.18.52.PM.mov