live: Explicitly require exp for sending Studio updates.
#507
Conversation
daavoo
force-pushed
the
require-exp-for-studio
branch
from
5de13c8 to
5cc444c
Compare
There was a problem hiding this comment.
@dberenbaum The discussion in #474 was stalling but since we are moving forward in Sudio towards unifying Live Experiments and Experiment refs (i.e. https://github.com/iterative/studio/issues/5453 , https://github.com/iterative/studio/pull/5417), I think it's better to stop allowing sending updates without an experiment.
Requires using either `dvc exp run` or `save_dvc_exp=True`. Closes #474
daavoo
force-pushed
the
require-exp-for-studio
branch
from
5cc444c to
62880aa
Compare
|
@daavoo I'm not against this, but I still feel like I'm maybe missing the motivation. Does it help simplify something? |
My main motivation is that I think of the use cases that this P.R forbids as lose ends.
It allows Studio to use baseline SHA and experiment name pair as unique identifier for all live experiments, which makes thing simpler on their end and sabes the need of changes to the client. It also allows both running and completed experiments to be referenced by URL using the same logic |
There was a problem hiding this comment.
It allows Studio to use baseline SHA and experiment name pair as unique identifier for all live experiments, which makes thing simpler on their end and sabes the need of changes to the client.
It also allows both running and completed experiments to be referenced by URL using the same logic
Okay, this seems like enough reason since we don't have any strong argument in the other direction. Thanks for explaining.
Requires using either
dvc exp runorsave_dvc_exp=True.Closes #474