-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement log_artifact method for live #464
Conversation
- Don't use `commit` - Don't raise error - Add `test_log_artifact`
@daavoo Sorry for the potential change in direction here, but I worry it's not very useful to add a
See #468 for an alternative to help with the pipeline transition. We could keep the initial scope narrow to not completely block |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Discussed with @daavoo to not block to wait for #468. Inside pipelines, this can even be used as is if the artifact is not specified as a pipeline output. I'm trying to help address the transition to pipelines with iterative/dvc#9138. |
for more information, see https://pre-commit.ci
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
==========================================
- Coverage 96.08% 95.92% -0.17%
==========================================
Files 38 39 +1
Lines 2401 2451 +50
Branches 199 203 +4
==========================================
+ Hits 2307 2351 +44
- Misses 55 59 +4
- Partials 39 41 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fix: #378