Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live: get rid of ParameterAlreadyLoggedError #316

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

dtrifiro
Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Base: 95.01% // Head: 94.88% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (3e6c3db) compared to base (a4ca09e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   95.01%   94.88%   -0.13%     
==========================================
  Files          36       36              
  Lines        1746     1702      -44     
  Branches      200      189      -11     
==========================================
- Hits         1659     1615      -44     
  Misses         64       64              
  Partials       23       23              
Impacted Files Coverage Δ
src/dvclive/live.py 94.76% <ø> (-0.16%) ⬇️
tests/test_main.py 100.00% <ø> (ø)
src/dvclive/error.py 88.88% <100.00%> (-2.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dberenbaum dberenbaum merged commit 129c8fa into main Sep 29, 2022
@dberenbaum dberenbaum deleted the remove-parameter-already-logged branch September 29, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants