-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plots: make output structure consistent between plot types #326
Comments
I think it makes sense as default behavior, but doesn't really fix the use case of wanting to visualize image updates across epochs (iterative/vscode-dvc#1640). A nested structure makes sense for that use case and anyhow if users want that structure they can manually generate it (and we can document it) as follows: live.log_image(f"{live.get_step()}/img.png", img) |
What about |
It was initially introduced for supporting different logging format between step and not step updates. For `live.log_image`, "step" mode now overwrites the path instead of creating subfolder by step. For `live.log`, the "no step" was meant to not generate the `.tsv` file but only the `.json`. Added a public property `summary` so "no step" scenarios can work as follows: ``` live = Live() live.summary["foo"] = 1 live.make_summary() ``` Closes #326 Apply suggestions from code review Co-authored-by: Paweł Redzyński <[email protected]>
…s. (#331) It was initially introduced for supporting different logging format between step and not step updates. For `live.log_image`, "step" mode now overwrites the path instead of creating subfolder by step. For `live.log`, the "no step" was meant to not generate the `.tsv` file but only the `.json`. Added a public property `summary` so "no step" scenarios can work as follows: ``` live = Live() live.summary["foo"] = 1 live.make_summary() ``` Closes #326 Apply suggestions from code review Co-authored-by: Paweł Redzyński <[email protected]> Co-authored-by: Paweł Redzyński <[email protected]>
…s. (#331) It was initially introduced for supporting different logging format between step and not step updates. For `live.log_image`, "step" mode now overwrites the path instead of creating subfolder by step. For `live.log`, the "no step" was meant to not generate the `.tsv` file but only the `.json`. Added a public property `summary` so "no step" scenarios can work as follows: ``` live = Live() live.summary["foo"] = 1 live.make_summary() ``` Closes #326 Apply suggestions from code review Co-authored-by: Paweł Redzyński <[email protected]> Co-authored-by: Paweł Redzyński <[email protected]>
…s. (#331) It was initially introduced for supporting different logging format between step and not step updates. For `live.log_image`, "step" mode now overwrites the path instead of creating subfolder by step. For `live.log`, the "no step" was meant to not generate the `.tsv` file but only the `.json`. Added a public property `summary` so "no step" scenarios can work as follows: ``` live = Live() live.summary["foo"] = 1 live.make_summary() ``` Closes #326 Apply suggestions from code review Co-authored-by: Paweł Redzyński <[email protected]> Co-authored-by: Paweł Redzyński <[email protected]>
…s. (#331) It was initially introduced for supporting different logging format between step and not step updates. For `live.log_image`, "step" mode now overwrites the path instead of creating subfolder by step. For `live.log`, the "no step" was meant to not generate the `.tsv` file but only the `.json`. Added a public property `summary` so "no step" scenarios can work as follows: ``` live = Live() live.summary["foo"] = 1 live.make_summary() ``` Closes #326 Apply suggestions from code review Co-authored-by: Paweł Redzyński <[email protected]> Co-authored-by: Paweł Redzyński <[email protected]>
Follow up to #322.
The difference in behavior between
log_image
andlog_sklearn_plot
bothers me:Now that they both get saved under
plots
, it seems more odd that they have such different behavior and output structure.images
create a new folder for each step, whilesklearn
throws an exception when used with multiple steps. #271 will only make this more complicated.For 1.0, dvclive should be more consistently opinionated. Since the focus has shifted a bit from serverless live tracking to more of a convenience for dvc logging, I would vote to overwrite plots at each step since this is how tools like dvc plots diff, vs code, and studio expect them (this was my mistake pushing for the nested structure originally). That would mean the output would look like:
The text was updated successfully, but these errors were encountered: