Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: get_cloud_fs: accept config instead of repo #9755

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jul 24, 2023

Config is a more immutable thing and using repo is confusing and might be error prone in the bigger picture.

Related/pre-requisite to #9754

@efiop efiop added refactoring Factoring and re-factoring skip-changelog Skips changelog labels Jul 24, 2023
@efiop efiop force-pushed the index-config branch 3 times, most recently from 1b4fbfb to e33a12b Compare July 24, 2023 21:25
Config is a more immutable thing and using `repo` is confusing and might be error
prone in the bigger picture.

Related to iterative#9754
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.27% ⚠️

Comparison is base (7806afd) 90.47% compared to head (6b587ec) 90.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9755      +/-   ##
==========================================
- Coverage   90.47%   90.20%   -0.27%     
==========================================
  Files         480      480              
  Lines       36595    36588       -7     
  Branches     5264     5263       -1     
==========================================
- Hits        33108    33003     -105     
- Misses       2889     2964      +75     
- Partials      598      621      +23     
Files Changed Coverage Δ
dvc/cachemgr.py 73.68% <100.00%> (ø)
dvc/data_cloud.py 68.18% <100.00%> (ø)
dvc/fs/__init__.py 100.00% <100.00%> (ø)
dvc/output.py 84.26% <100.00%> (ø)
tests/unit/fs/test_fs.py 93.33% <100.00%> (-0.96%) ⬇️
tests/unit/fs/test_tree.py 100.00% <100.00%> (ø)
tests/unit/remote/test_remote.py 100.00% <100.00%> (ø)
tests/unit/remote/test_webdav.py 100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop efiop merged commit 65ba9ba into iterative:main Jul 24, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Factoring and re-factoring skip-changelog Skips changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant