Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp list: show experiment shas #9501

Merged
merged 7 commits into from
May 25, 2023
Merged

exp list: show experiment shas #9501

merged 7 commits into from
May 25, 2023

Conversation

dberenbaum
Copy link
Collaborator

@dberenbaum dberenbaum commented May 24, 2023

Shows experiment SHAs like this:

$ dvc exp list -A
notebook:
        4e8a178 [burnt-sera]
        5cdc6a9 [liked-pees]
        0ec726a [unwed-kana]

Not supported for git remotes, where it continues to show the old format:

$ dvc exp list -A origin
0361ee4:
        extra-hunk

Also adds --sha-only arg (not supported for git remotes), which outputs like:

$ dvc exp list -A --sha-only
f1edf21
1d4c01d
f8f9be7

@dberenbaum dberenbaum requested review from daavoo and pmrowla and removed request for daavoo May 24, 2023 00:46
results[name] = [info.name for info in ref_info_dict[baseline]]
for info in ref_info_dict[baseline]:
if git_remote:
exp_rev = None
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there's an easy way to get the rev of a remote ref. Skipped it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is possible to do but it's not implemented right now in scmrepo, we can add it in the future if it's actually needed

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 πŸŽ‰

Comparison is base (79c8800) 91.16% compared to head (4618b6c) 91.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9501      +/-   ##
==========================================
+ Coverage   91.16%   91.18%   +0.02%     
==========================================
  Files         474      474              
  Lines       36692    36731      +39     
  Branches     5226     5233       +7     
==========================================
+ Hits        33449    33494      +45     
+ Misses       2686     2681       -5     
+ Partials      557      556       -1     
Impacted Files Coverage Ξ”
tests/func/experiments/test_remote.py 100.00% <ΓΈ> (ΓΈ)
dvc/commands/experiments/ls.py 100.00% <100.00%> (+24.00%) ⬆️
dvc/repo/experiments/ls.py 100.00% <100.00%> (ΓΈ)
tests/func/experiments/test_experiments.py 100.00% <100.00%> (ΓΈ)
tests/func/experiments/test_save.py 100.00% <100.00%> (ΓΈ)
tests/unit/command/test_experiments.py 100.00% <100.00%> (ΓΈ)

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

dvc/repo/experiments/ls.py Outdated Show resolved Hide resolved
@pmrowla pmrowla merged commit 8acd943 into main May 25, 2023
@pmrowla pmrowla deleted the exp-ls-sha branch May 25, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants